atom: fix build on macOS 10.14 #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libstdc++ was removed and we need to make sure that modules are built against libc++. We can do so by setting macOS 10.9 as minimum target in CFLAGS, CXXFLAGS and LDFLAGS. While here, it may be a good idea to export these variables always with macports' default values. Fixes https://trac.macports.org/ticket/57243
|
Notifying maintainers: |
|
Travis Build #3859 Errored. Lint resultsPort atom's dependencies fail on xcode9.4. Log |
|
Merged! Thanks, @michaellass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libstdc++ was removed in Mojave and we need to make sure that atom and its modules are built against libc++. We can do so by setting macOS 10.9 as minimum target in CFLAGS, CXXFLAGS and LDFLAGS.
While here, it may be a good idea to export these variables always with macports' default values.
Type(s)
Tested on
macOS 10.14 18A391
Xcode 10.0 10A255
Verification
Have you
port lint?sudo port -vst install?