Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: fix test for SDK newer than 10.6 #2740

Merged
merged 1 commit into from Oct 7, 2018
Merged

vim: fix test for SDK newer than 10.6 #2740

merged 1 commit into from Oct 7, 2018

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Oct 7, 2018

closes: https://trac.macports.org/ticket/56994

Fixes build on 10.4 and 10.5. Confirmed to build correctly still on 10.14 with no deprecation warnings.

See vim/vim#3022

@macportsbot
Copy link

Notifying maintainers:
@raimue for port vim.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: requires approval labels Oct 7, 2018
@kencu kencu mentioned this pull request Oct 7, 2018
Closed
@macportsbot
Copy link

Travis Build #3880 Passed.

Lint results 
--->  Verifying Portfile for vim
Warning: Variant x11 overrides global description
--->  0 errors and 1 warnings found.

Port vim success on xcode8.3. Log
Port vim success on xcode7.3. Log
Port vim success on xcode10. Log

@raimue
Copy link
Member

raimue commented Oct 7, 2018

I have no way to test this, but the change looks good to me.

I was going to suggest to also submit this to upstream, but I see that is already where the patch originates. 👍

@raimue raimue merged commit 12828a4 into macports:master Oct 7, 2018
@kencu kencu deleted the vimfix branch October 11, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raimue raimue

Labels
by: member Created by a member with commit rights maintainer: requires approval
Milestone
No milestone
3 participants
@kencu @macportsbot @raimue