Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rb19-bundler: Update by merging with rb-bundler #2771

Merged
merged 1 commit into from Oct 18, 2018

Conversation

ryandesign
Copy link
Contributor

Description

rb19-bundler: Update by merging with rb-bundler

Closes: https://trac.macports.org/ticket/43224

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G65
Xcode 9.4.1 9F2000

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@kimuraw for port rb-bundler.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port labels Oct 9, 2018
@macportsbot
Copy link

Travis Build #3925 Passed.

Lint results
--->  Verifying Portfile for rb-bundler
--->  0 errors and 0 warnings found.

Port rb-bundler success on xcode9.4. Log
Port rb19-bundler success on xcode9.4. Log
Port rb23-bundler success on xcode9.4. Log
Port rb24-bundler success on xcode9.4. Log
Port rb25-bundler success on xcode9.4. Log
Port rb-bundler success on xcode8.3. Log
Port rb19-bundler success on xcode8.3. Log
Port rb23-bundler success on xcode8.3. Log
Port rb24-bundler success on xcode8.3. Log
Port rb25-bundler success on xcode8.3. Log
Port rb-bundler success on xcode7.3. Log
Port rb19-bundler success on xcode7.3. Log
Port rb23-bundler success on xcode7.3. Log
Port rb24-bundler success on xcode7.3. Log
Port rb25-bundler success on xcode7.3. Log
Port rb-bundler success on xcode10. Log
Port rb19-bundler success on xcode10. Log
Port rb23-bundler success on xcode10. Log
Port rb24-bundler success on xcode10. Log

@pmetzger
Copy link
Member

I know relatively little about our Ruby infra, but LGTM as far as I can tell. That said, Ruby 19 is long out of support (over three years since EOL) and probably all the Ruby 19 stuff should just go.

@macportsbot
Copy link

Travis Build #3944 Passed.

Lint results
--->  Verifying Portfile for rb-bundler
--->  0 errors and 0 warnings found.

Port rb-bundler success on xcode9.4. Log
Port rb19-bundler success on xcode9.4. Log
Port rb23-bundler success on xcode9.4. Log
Port rb24-bundler success on xcode9.4. Log
Port rb25-bundler success on xcode9.4. Log
Port rb-bundler success on xcode8.3. Log
Port rb19-bundler success on xcode8.3. Log
Port rb23-bundler success on xcode8.3. Log
Port rb24-bundler success on xcode8.3. Log
Port rb25-bundler success on xcode8.3. Log
Port rb-bundler success on xcode7.3. Log
Port rb19-bundler success on xcode7.3. Log
Port rb23-bundler success on xcode7.3. Log
Port rb24-bundler success on xcode7.3. Log
Port rb25-bundler success on xcode7.3. Log
Port rb-bundler success on xcode10. Log
Port rb19-bundler success on xcode10. Log
Port rb23-bundler success on xcode10. Log
Port rb24-bundler success on xcode10. Log

@pmetzger
Copy link
Member

Anyway, I leave the decision about merging to you and others. As I said, though, I think we should be obsoleting Ruby 1.9 support entirely, and as soon as possible given the number of security vulnerabilities that have gone unpatched.

@kimuraw kimuraw merged commit 2acb494 into macports:master Oct 18, 2018
@ryandesign ryandesign deleted the rb19-bundler-update branch October 18, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
4 participants