Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miriad: fix compilation on gfortran >= 8.1 #2899

Merged
merged 1 commit into from Oct 30, 2018
Merged

miriad: fix compilation on gfortran >= 8.1 #2899

merged 1 commit into from Oct 30, 2018

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Oct 30, 2018

Description

As per https://trac.macports.org/ticket/57434 . The most recent gfortran adds a new error that gets triggered in this package. It is unlikely that we'll see a new upstream release, so we add a new patch to fix the problems.

Also, register my GitHub username (@pkgw).

Also, remove the old mm.f2c debugging patch; the problem seems to be solved. At least, I have not heard any reports of problems for literally years.

Note: my branch failed CI and I haven't been able to test locally because my computer is burning itself up compiling gcc; I just wanted to submit this before I call it quits for the night.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
macOS 10.12.6 16G1510
Xcode 8.3.1 8E1000a
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

[skip notification]

@pkgw
miriad: fix compilation on gfortran >= 8.1
463f359 
As per https://trac.macports.org/ticket/57434 . The most recent gfortran adds
a new error that gets triggered in this package. It is unlikely that we'll
see a new upstream release, so we add a new patch to fix the problems.

Also, register my GitHub username (@pkgw).

Also, remove the old mm.f2c debugging patch; the problem seems to be solved.
At least, I have not heard any reports of problems for literally years.

Closes: https://trac.macports.org/ticket/57434.
@macportsbot
Copy link

Travis Build #4129 Errored.

Lint results 
--->  Verifying Portfile for miriad
Warning: Variant gcc_select conflicts with non-existing variant g95 gcc44 gcc45 gcc46 gcc47 gcc48 gcc49 gcc5 gcc6 gcc7 gcc8
--->  0 errors and 1 warnings found.

Port miriad success on xcode9.4. Log
Port miriad fail on xcode8.3. Log
Port miriad success on xcode7.3. Log

@pmetzger pmetzger merged commit 54e0045 into macports:master Oct 30, 2018
@pmetzger
Copy link
Member

I've merged this. Thanks for the update, @pkgw. Please pay attention to what the buildbots do.

@pkgw pkgw deleted the fix-miriad branch October 30, 2018 16:09
@ryandesign
Copy link
Contributor

Please pay attention to what the buildbots do.

Looks good: https://packages.macports.org/miriad/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez Awaiting requested review from MarcusCalhoun-Lopez

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port maintainer type: bugfix
Milestone
No milestone
4 participants
@pkgw @macportsbot @pmetzger @ryandesign