Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid4: add "-lresolv" to kerberos variant #3063

Closed
wants to merge 1 commit into from
Closed

squid4: add "-lresolv" to kerberos variant #3063

wants to merge 1 commit into from

Conversation

TP75
Copy link
Contributor

@TP75 TP75 commented Nov 21, 2018

Refering to ​

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G3025
Xcode 10.1 10B61

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@jmroot for port squid4.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: bugfix labels Nov 21, 2018
@macportsbot
Copy link

Travis Build #4381 Passed.

Lint results
--->  Verifying Portfile for squid4
--->  0 errors and 0 warnings found.

Port squid4 success on xcode9.4. Log
Port squid4 success on xcode8.3. Log
Port squid4 success on xcode7.3. Log
Port squid4 success on xcode10.1. Log

@jmroot jmroot closed this in b8a6e10 Nov 22, 2018
@@ -5,6 +5,7 @@ PortGroup cxx11 1.1

name squid4
version 4.4
revision 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No revision increase should be done when fixing a build failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. How to diffenrentiate between the Portfile versions?

Loooking into the MacPorts Guide 5.4. Global Keywords there are:

  1. version - The version of the ported software. (not the version of the port)
  2. revision - used to track port revisions.
  3. epoch - must be used when a port is updated to a version that is numerically less than the previous version

What did I miss?

@TP75 TP75 deleted the workaround branch November 23, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
3 participants