Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Cross Compilers #3329

Merged
merged 5 commits into from
Jan 5, 2019
Merged

Revamp Cross Compilers #3329

merged 5 commits into from
Jan 5, 2019

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.2
Xcode 10.1

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@g5pw for port avr-binutils, avr-gcc.
@mojca for port i686-w64-mingw32-gcc, x86_64-w64-mingw32-gcc.

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez mentioned this pull request Jan 4, 2019
Closed
11 tasks
@macportsbot
Copy link

Travis Build #4764 Errored.

Lint results 
--->  Verifying Portfile for arm-aout-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-linux-gnueabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i686-w64-mingw32-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for m68k-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mips-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ppc-linux-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for spu-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-w64-mingw32-gcc
--->  0 errors and 0 warnings found.

Port arm-aout-binutils success on xcode9.4. Log
Port arm-elf-binutils success on xcode9.4. Log
Port arm-none-eabi-binutils success on xcode9.4. Log
Port arm-aout-binutils success on xcode8.3. Log
Port arm-elf-binutils success on xcode8.3. Log
Port arm-none-eabi-binutils success on xcode8.3. Log
Port arm-aout-binutils success on xcode7.3. Log
Port arm-elf-binutils success on xcode7.3. Log
Port arm-none-eabi-binutils success on xcode7.3. Log
Port arm-aout-binutils success on xcode10.1. Log
Port arm-elf-binutils success on xcode10.1. Log
Port arm-none-eabi-binutils success on xcode10.1. Log

The build timed out.

mojca
mojca approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@mojca mojca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I find it somewhat ugly to repeat the same code over and over again, but admittedly there aren't that many alternatives, and according to an email from July 8.3.0 is scheduled around this time, so hopefully we could remove the patches soon again.

In case you're in a mood for these :)
https://trac.macports.org/ticket/55213
https://trac.macports.org/ticket/57575

but otherwise this looks good to me, and certainly more complete than fixing just a single port. (I was hoping there would be a more generic solution.)

cross/arm-aout-binutils/Portfile Show resolved Hide resolved
_resources/port1.0/group/crossgcc-1.0.tcl Show resolved Hide resolved
cross/arm-none-eabi-gcc/Portfile Outdated Show resolved Hide resolved
cross/arm-none-eabi-gcc/Portfile Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #4768 Errored.

Lint results 
--->  Verifying Portfile for arm-aout-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-linux-gnueabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i686-w64-mingw32-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for m68k-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mips-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ppc-linux-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for spu-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-w64-mingw32-gcc
--->  0 errors and 0 warnings found.

Port arm-aout-binutils success on xcode9.4. Log
Port arm-elf-binutils success on xcode9.4. Log
Port arm-none-eabi-binutils success on xcode9.4. Log
Port arm-aout-binutils success on xcode8.3. Log
Port arm-elf-binutils success on xcode8.3. Log
Port arm-none-eabi-binutils success on xcode8.3. Log
Port arm-aout-binutils success on xcode7.3. Log
Port arm-elf-binutils success on xcode7.3. Log
Port arm-none-eabi-binutils success on xcode7.3. Log
Port arm-aout-binutils success on xcode10.1. Log
Port arm-elf-binutils success on xcode10.1. Log
Port arm-none-eabi-binutils success on xcode10.1. Log

The build timed out.

@macportsbot
Copy link

Travis Build #4769 Errored.

Lint results 
--->  Verifying Portfile for arm-aout-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-eabi-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for arm-none-linux-gnueabi-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avr-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i386-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for i686-w64-mingw32-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for m68k-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mips-elf-binutils
--->  0 errors and 0 warnings found.
Warning: All compilers are either blacklisted or unavailable; defaulting to first fallback option
--->  Verifying Portfile for msp430-gcc-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for msp430-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ppc-linux-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for spu-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-binutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-elf-gcc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for x86_64-w64-mingw32-gcc
--->  0 errors and 0 warnings found.

Port arm-aout-binutils success on xcode9.4. Log
Port arm-elf-binutils success on xcode9.4. Log
Port arm-none-eabi-binutils success on xcode9.4. Log
Port arm-aout-binutils success on xcode8.3. Log
Port arm-elf-binutils success on xcode8.3. Log
Port arm-none-eabi-binutils success on xcode8.3. Log
Port arm-aout-binutils success on xcode7.3. Log
Port arm-elf-binutils success on xcode7.3. Log
Port arm-none-eabi-binutils success on xcode7.3. Log
Port arm-aout-binutils success on xcode10.1. Log
Port arm-elf-binutils success on xcode10.1. Log
Port arm-none-eabi-binutils success on xcode10.1. Log

The build timed out.

@mojca
Copy link
Member

mojca commented Jan 5, 2019

See also #3336 for an unfinished attempt to make the msp430 work.

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez merged commit 002d49a into macports:master Jan 5, 2019
@MarcusCalhoun-Lopez MarcusCalhoun-Lopez deleted the cross_isl branch January 5, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojca mojca mojca approved these changes

Assignees

@mojca mojca

@g5pw g5pw

Labels
by: member Created by a member with commit rights maintainer: requires approval type: bugfix type: enhancement
Milestone
No milestone
4 participants
@MarcusCalhoun-Lopez @macportsbot @mojca @g5pw