Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-protobuf: conflict with py-protobuf3 (and vice versa) #3415

Merged
merged 1 commit into from Jan 14, 2019

Conversation

mojca
Copy link
Member

@mojca mojca commented Jan 13, 2019

Triggered by a recent email on the mailing list.

I suspect this also needs a revbump of both ports?

Type(s)
  • bugfix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@blair for port py-protobuf.

@macportsbot
Copy link

Travis Build #4887 Passed.

Lint results
--->  Verifying Portfile for py-protobuf
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-protobuf3
--->  0 errors and 0 warnings found.

Port py27-protobuf success on xcode9.4. Log
Port py-protobuf success on xcode9.4. Log
Port py27-protobuf3 success on xcode9.4. Log
Port py-protobuf3 success on xcode9.4. Log
Port py35-protobuf3 success on xcode9.4. Log
Port py36-protobuf3 success on xcode9.4. Log
Port py37-protobuf3 success on xcode9.4. Log
Port py27-protobuf success on xcode8.3. Log
Port py-protobuf success on xcode8.3. Log
Port py27-protobuf3 success on xcode8.3. Log
Port py-protobuf3 success on xcode8.3. Log
Port py35-protobuf3 success on xcode8.3. Log
Port py36-protobuf3 success on xcode8.3. Log
Port py37-protobuf3 success on xcode8.3. Log
Port py27-protobuf success on xcode7.3. Log
Port py-protobuf success on xcode7.3. Log
Port py27-protobuf3 success on xcode7.3. Log
Port py-protobuf3 success on xcode7.3. Log
Port py35-protobuf3 success on xcode7.3. Log
Port py36-protobuf3 success on xcode7.3. Log
Port py37-protobuf3 success on xcode7.3. Log
Port py27-protobuf success on xcode10.1. Log
Port py-protobuf success on xcode10.1. Log
Port py27-protobuf3 success on xcode10.1. Log
Port py-protobuf3 success on xcode10.1. Log
Port py35-protobuf3 success on xcode10.1. Log
Port py36-protobuf3 success on xcode10.1. Log
Port py37-protobuf3 success on xcode10.1. Log

@blair blair merged commit 2402ac7 into macports:master Jan 14, 2019
@blair
Copy link
Contributor

blair commented Jan 14, 2019

I don't know if it needs a revbump, that check may be done before port downloads the tarball? In any case, the commit LGTM.

@pmetzger
Copy link
Member

@mojca I think we should just be removing the old py-protobuf because nothing should depend on it any longer (and if anything does, it is quite obsolete itself.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants