Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-backports.weakref: declare py34/py35/py36 obsolete #3612

Merged
merged 1 commit into from Feb 11, 2019

Conversation

reneeotten
Copy link
Contributor

Description

When trying to fix ticket 58004 I moved the subports incorrectly to py-graveyard, which set them to be replaced_by py37-backports.weakref. Instead they should be set to obsolete.

I think this PR fixes this, but I am not 100% sure that this is the suggested/correct approach and whether removing the port from py-graveyard has any unwanted/unexpected consequences. Perhaps @ryandesign or someone else wants to comment before merging this?

Closes: https://trac.macports.org/ticket/58038

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.3 18D42
Xcode 10.1 10B61

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test? N/A
  • tried a full install with sudo port -vst install? N/A
  • tested basic functionality of all binary files? N/A

@macportsbot
Copy link

Notifying maintainers:
@emcrisostomo for port py-backports.weakref.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: bugfix labels Feb 9, 2019
@jmroot
Copy link
Member

jmroot commented Feb 9, 2019

If there's no replacement, just delete the (sub)port.

@reneeotten
Copy link
Contributor Author

If there's no replacement, just delete the (sub)port.

okay, that is certainly the easiest solution. So I can just delete them from py-graveyard and that's all? How does that work then for people who already have let's say py36-backports.weakref installed; what become the status of that (sub)port for them? Will it be uninstalled next time they do an port upgrade outdated; I guess that's what I am confused about?

@macportsbot
Copy link

Travis Build #5200 Passed.

Lint results
--->  Verifying Portfile for py-backports.weakref
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-graveyard
Error: Missing required variable: platforms
Error: Missing required variable: homepage
Warning: no license set
--->  2 errors and 1 warnings found.

Port py27-backports.weakref success on xcode9.4. Log
Port py-backports.weakref success on xcode9.4. Log
Port py27-backports.weakref success on xcode8.3. Log
Port py-backports.weakref success on xcode8.3. Log
Port py27-backports.weakref success on xcode7.3. Log
Port py-backports.weakref success on xcode7.3. Log
Port py27-backports.weakref success on xcode10.1. Log

@jmroot
Copy link
Member

jmroot commented Feb 9, 2019

How does that work then for people who already have let's say py36-backports.weakref installed; what become the status of that (sub)port for them?

It will be installed and no longer in the index. The obsolete pseudo-portname matches such ports.

I moved them incorrectly to py-graveyard, which set them to be
replaced_by py37-backports.weakref

Closes: https://trac.macports.org/ticket/58038
@macportsbot
Copy link

Travis Build #5202 Passed.

Lint results
--->  Verifying Portfile for py-graveyard
Error: Missing required variable: platforms
Error: Missing required variable: homepage
Warning: no license set
--->  2 errors and 1 warnings found.

@pmetzger pmetzger merged commit 1dc8f2a into macports:master Feb 11, 2019
@pmetzger
Copy link
Member

Merged. Thanks, @reneeotten!

@reneeotten reneeotten deleted the py-backports.weakref branch February 12, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
5 participants