Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: Update fish shell to 2.4.0 version #37

Closed
wants to merge 0 commits into from
Closed

Conversation

dgsb
Copy link
Contributor

@dgsb dgsb commented Nov 13, 2016

Update the source tarball to 2.4.0 version.
The following patches, which are now unneeded, have also been removed

  • patch-ambiguous-overload.diff: unneeded since commit a8af9748954 2013-08-25
  • patch-c++11-tr1.diff: This patch has been commited in the main repo in 7541fac2
  • patch-proc_c.diff: This patch is in mainstream since e9d1a54

Closes: https://trac.macports.org/ticket/52872

Copy link
Member

@raimue raimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, the $Id$ tag could also be removed now.

@@ -4,7 +4,7 @@
PortSystem 1.0
PortGroup github 1.0

github.setup fish-shell fish-shell 2.3.1
github.setup fish-shell fish-shell 2.4.0
revision 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revision should be removed when the version is increased.

@dgsb
Copy link
Contributor Author

dgsb commented Nov 14, 2016

The requested changes has been done in the second commit

@larryv
Copy link
Member

larryv commented Nov 14, 2016

I botched this PR, but changes committed in 3d7f4e2. Thanks.

raimue referenced this pull request Nov 14, 2016
The following patches, which are now unneeded, have also been removed
 * patch-ambiguous-overload.diff: unneeded since commit a8af9748954
   2013-08-25
 * patch-c++11-tr1.diff: This patch has been commited in the main repo
   in 7541fac2
 * patch-proc_c.diff: This patch is in mainstream since e9d1a54

Closes: https://trac.macports.org/ticket/52872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants