Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gegl-0.4: support legacy systems #3776

Merged
merged 1 commit into from Mar 4, 2019
Merged

gegl-0.4: support legacy systems #3776

merged 1 commit into from Mar 4, 2019

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Mar 4, 2019

gegl uses realpath with NULL buffer ptr
so needs legacysupport to support this

luajit presently does not build on PowerPC
gegl-0.4 builds through successfully without it

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.5.8
Xcode 3.2.6

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@dbevans for port gegl-0.4.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels Mar 4, 2019
dbevans
dbevans previously requested changes Mar 4, 2019
Copy link
Contributor

@dbevans dbevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of this version, luajit is required in addition to lua itself for lua support.
Thus you can delete the dependency on lua itself as well.
And since deleting the dependencies is not sufficient to ensure luajit/lua are not installed by something else you should also forceably disable lua support using --without-lua to make the point.

This should be done for gegl-devel as well since the two are almost the same at this point.

@kencu
Copy link
Contributor Author

kencu commented Mar 4, 2019

thanks dave.

@macportsbot
Copy link

Travis Build #5453 Errored.

Lint results
--->  Verifying Portfile for gegl-0.4
--->  0 errors and 0 warnings found.

The build timed out.

@kencu
Copy link
Contributor Author

kencu commented Mar 4, 2019

I have taken a slight detour while I try to see if luajit PPC is fixable.

@mojca
Copy link
Member

mojca commented Mar 4, 2019

I have taken a slight detour while I try to see if luajit PPC is fixable.

Fixable as in "builds at all" or fixable as in "works correctly"? I had some success with the first one, but not with the second. I forwarded you some of my super old notes.

@mojca
Copy link
Member

mojca commented Mar 4, 2019

Off-topic: LuaTeX will likely drop support for luajit in the future after realizing that there are hardly any performance benefits, and luajit is likely stuck with 5.1 forever. I forgot whether performance got better with newer versions of lua, or if it's simply because optimisations brought by luajit do not exactly make any difference in that particular application.

@kencu
Copy link
Contributor Author

kencu commented Mar 4, 2019

Yes - builds and crashes. May be a lost cause if the PPC Darwin 32bit ABI has not been integrated into luajit source -- same issue I have with llvm, where some of that ABI is not yet written. I found this ticket https://trac.macports.org/ticket/45343 which is a clue. I was going to try monkeying around with the optimization level and maybe set some ASSERTs, but ...

gegl uses realpath with NULL buffer ptr
so needs legacysupport to support this

luajit presently does not build properly on PowerPC
@kencu
Copy link
Contributor Author

kencu commented Mar 4, 2019

dave, I implemented your suggestions, so I'll just go ahead with this now rather than bug you further about it.

@kencu kencu merged commit 8c6bd10 into macports:master Mar 4, 2019
@kencu kencu deleted the gegleofix branch March 4, 2019 16:57
@dbevans
Copy link
Contributor

dbevans commented Mar 4, 2019

Thanks for the help, Ken.

@barracuda156
Copy link
Contributor

I have taken a slight detour while I try to see if luajit PPC is fixable.

luajit is fixed for PPC now: https://trac.macports.org/ticket/64853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
5 participants