Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xchm: switch to github, update #3804

Merged
merged 1 commit into from Mar 8, 2019
Merged

xchm: switch to github, update #3804

merged 1 commit into from Mar 8, 2019

Conversation

mojca
Copy link
Member

@mojca mojca commented Mar 7, 2019

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install? (it's currently broken)
  • tested basic functionality of all binary files?

There is still one issues with wxWidgets, I would like to ask @rzvncj for help.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port labels Mar 7, 2019
@mojca mojca added the wip Work in progress label Mar 7, 2019
@macportsbot
Copy link

Travis Build #5503 Failed.

Lint results 
--->  Verifying Portfile for xchm
--->  0 errors and 0 warnings found.

Port xchm fail on xcode10.2. Log
Port xchm fail on xcode9.4. Log
Port xchm fail on xcode8.3. Log
Port xchm fail on xcode7.3. Log

mf2k
mf2k requested changes Mar 7, 2019
View reviewed changes
textproc/xchm/Portfile Outdated Show resolved Hide resolved
textproc/xchm/Portfile Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #5507 Failed.

Lint results 
--->  Verifying Portfile for xchm
--->  0 errors and 0 warnings found.

Port xchm fail on xcode10.2. Log
Port xchm fail on xcode9.4. Log
Port xchm fail on xcode8.3. Log
Port xchm fail on xcode7.3. Log

@rzvncj
Copy link

rzvncj commented Mar 7, 2019

I've worked around the issue, but this is definitely a wxWidgets bug. It would appear that at least wxWidgets 3.0 has not caught up with C++11 and nullptr. Please try again with the master branch. If all's well, I'll do a formal/tagged release. Thanks.

@mojca
Copy link
Member Author

mojca commented Mar 8, 2019

@rzvncj: it looks better now.

If you want some automatic testing on mac, you could set up CI on Azure Pipelines (Travis is also an option, but we have lots of issues with it, in particular its time limit is too short, but they also just fired most developers).

We can wait with merging this until there is a tagged release available.

@mojca
Copy link
Member Author

mojca commented Mar 8, 2019

Also, if you feel there's an upstream bug in wxWidgets, please report it.

@macportsbot
Copy link

Travis Build #5525 Passed.

Lint results 
--->  Verifying Portfile for xchm
--->  0 errors and 0 warnings found.

Port xchm success on xcode10.2. Log
Port xchm success on xcode9.4. Log
Port xchm success on xcode8.3. Log
Port xchm success on xcode7.3. Log

@rzvncj
Copy link

rzvncj commented Mar 8, 2019

Here's the new tagged release: https://github.com/rzvncj/xCHM/releases/tag/1.26

@rzvncj
Copy link

rzvncj commented Mar 8, 2019

https://trac.wxwidgets.org/ticket/18355

@mojca mojca removed the wip Work in progress label Mar 8, 2019
@mojca mojca changed the title [WIP] xchm: switch to github, update xchm: switch to github, update Mar 8, 2019
@mojca
Copy link
Member Author

mojca commented Mar 8, 2019

@rzvncj: thank you very much.
To anyone else with commit access: feel free to merge if the build passes.

@macportsbot
Copy link

Travis Build #5534 Passed.

Lint results 
--->  Verifying Portfile for xchm
--->  0 errors and 0 warnings found.

Port xchm success on xcode10.2. Log
Port xchm success on xcode9.4. Log
Port xchm success on xcode8.3. Log

@mojca mojca merged commit 3098a77 into macports:master Mar 8, 2019
@mojca mojca deleted the xchm-github branch March 8, 2019 17:54
@rzvncj
Copy link

rzvncj commented Mar 8, 2019

No problem. Thank you for keeping the Mac xCHM build alive.

mojca added a commit to mojca/macports-ports that referenced this pull request Mar 9, 2019
@mojca
wxWidgets-3.0: add upstream patch for strings
ee55a54 
See: https://trac.wxwidgets.org/ticket/18355
See: wxWidgets/wxWidgets#1251
See: macports#3804
@mojca mojca mentioned this pull request Mar 9, 2019
Merged
11 tasks
mojca added a commit that referenced this pull request Mar 11, 2019
@mojca
wxWidgets-3.0: add upstream patch for strings
5145438 
See: https://trac.wxwidgets.org/ticket/18355
See: wxWidgets/wxWidgets#1251
See: #3804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2k mf2k mf2k approved these changes

Assignees
No one assigned
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer
Milestone
No milestone
4 participants
@mojca @macportsbot @rzvncj @mf2k