Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS: add PowerPC support #3815

Merged
merged 1 commit into from Mar 8, 2019
Merged

OpenBLAS: add PowerPC support #3815

merged 1 commit into from Mar 8, 2019

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Mar 8, 2019

These patches and the small change to force a newer make on Tiger fix the build of OpenBLAS on PowerPC macs.

It looks like these changes are acceptable to upstream, and these patches should be integrated into the next release of OpenBLAS.

PowerPC forever!

@macportsbot
Copy link

Notifying maintainers:
@NicosPavlov for port OpenBLAS.
@michaelld for port OpenBLAS.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port labels Mar 8, 2019
@macportsbot
Copy link

Travis Build #5526 Errored.

Lint results
--->  Verifying Portfile for OpenBLAS
--->  0 errors and 0 warnings found.

Port OpenBLAS success on xcode10.2. Log
Port OpenBLAS success on xcode9.4. Log
Port OpenBLAS-devel success on xcode9.4. Log
Port OpenBLAS success on xcode8.3. Log
Port OpenBLAS-devel success on xcode8.3. Log
Port OpenBLAS success on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #5527 Errored.

Lint results
--->  Verifying Portfile for OpenBLAS
--->  0 errors and 0 warnings found.

Port OpenBLAS success on xcode10.2. Log
Port OpenBLAS success on xcode9.4. Log
Port OpenBLAS-devel success on xcode9.4. Log
Port OpenBLAS success on xcode8.3. Log
Port OpenBLAS's dependencies fail on xcode7.3. Log
Port OpenBLAS-devel's dependencies fail on xcode7.3. Log

The build timed out.

@michaelld
Copy link
Contributor

Thanks for putting these all together, @kencu ! I'll test on my PPC G5 box today & report back. I love that the fixes are so minimal!

Copy link
Contributor

@michaelld michaelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When forcing the correct compiler, these changes work correctly. I'll figure out a change to get the "correct compiler" automatically after this PR is merged.

@michaelld
Copy link
Contributor

"correctly" meaning with no further changes to the Portfile or patches; just the compiler selection.

@michaelld
Copy link
Contributor

My testing was on 10.5 PPC only; I don't have a 10.4 PPC install yet ... so, we can take @kencu's word that it works on his 10.4 PPC install IMHO.

@kencu
Copy link
Contributor Author

kencu commented Mar 8, 2019

I continue to get gcc6 automatically on two different 10.4 PPC machines and my 10.5 PPC machine. -- I don't have to force any compilers.

Are you running the MacPorts' git devel branch??

@NicosPavlov
Copy link
Contributor

Thanks for following that up. As I have no testing capabilities on PowerPC, I leave it up to you.

@kencu
Copy link
Contributor Author

kencu commented Mar 8, 2019

$ machine
ppc970

$ uname -a
Darwin tigerg5.local 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc

$ port info
OpenBLAS @0.3.5_1 (math, science)
Sub-ports:            OpenBLAS-devel
Variants:             g95, gcc48, gcc49, gcc5, [+]gcc6, gcc7, gcc8, [+]lapack,
                      universal

Description:          OpenBLAS is an optimized BLAS library based on GotoBLAS2
Homepage:             https://github.com/xianyi/OpenBLAS

Build Dependencies:   cctools, gmake, gcc6
Library Dependencies: libgcc, libgcc7, libgcc6, gcc6
Test Dependencies:    gmake
Conflicts with:       OpenBLAS-devel
Platforms:            darwin
License:              BSD
Maintainers:          Email: nicos@macports.org, GitHub: NicosPavlov
                      Email: michaelld@macports.org, GitHub: michaelld
                      Policy: openmaintainer

@michaelld
Copy link
Contributor

{{{
$ machine
ppc970

$ uname -a
Darwin iMac-G5-10-5.local 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:57:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_PPC Power Macintosh

$ port info openblas
OpenBLAS @0.3.5_1 (math, science)
Sub-ports: OpenBLAS-devel
Variants: g95, gcc48, gcc49, gcc5, [+]gcc6, gcc7, gcc8, [+]lapack, universal

Description: OpenBLAS is an optimized BLAS library based on GotoBLAS2
Homepage: https://github.com/xianyi/OpenBLAS

Build Dependencies: cctools, gcc6, clang-7.0
Library Dependencies: libgcc, libgcc7, libgcc6
Conflicts with: OpenBLAS-devel
Platforms: darwin
License: BSD
Maintainers: Email: nicos@macports.org, GitHub: NicosPavlov
Email: michaelld@macports.org, GitHub: michaelld
Policy: openmaintainer
}}}

@michaelld
Copy link
Contributor

I have no special globally configured variants or compilers or other settings. I follow MP git master, and mostly install my own devel ports for testing / verification.

@kencu
Copy link
Contributor Author

kencu commented Mar 8, 2019

My guess is something might have changed in MP git master then. We can see when you push this -- if the 10.5 PPC buildbot builds it, then we'll know there's an issue in MP git master.

@michaelld
Copy link
Contributor

sounds good. I'm going to go ahead & merge then.

@michaelld michaelld merged commit cd5c8b2 into macports:master Mar 8, 2019
@kencu
Copy link
Contributor Author

kencu commented Mar 8, 2019

the buildbot picked gcc6 as well, so it must be something in base in git master we need to tweak. Goes without saying that at this point in time base should never be suggesting any clang compiler for PPC.

@kencu kencu deleted the openblasppc branch March 8, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
4 participants