New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBLAS: add PowerPC support #3815
Conversation
Notifying maintainers: |
Travis Build #5526 Errored. Lint results
Port OpenBLAS success on xcode10.2. Log The build timed out. |
Travis Build #5527 Errored. Lint results
Port OpenBLAS success on xcode10.2. Log The build timed out. |
Thanks for putting these all together, @kencu ! I'll test on my PPC G5 box today & report back. I love that the fixes are so minimal! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When forcing the correct compiler, these changes work correctly. I'll figure out a change to get the "correct compiler" automatically after this PR is merged.
"correctly" meaning with no further changes to the Portfile or patches; just the compiler selection. |
My testing was on 10.5 PPC only; I don't have a 10.4 PPC install yet ... so, we can take @kencu's word that it works on his 10.4 PPC install IMHO. |
I continue to get gcc6 automatically on two different 10.4 PPC machines and my 10.5 PPC machine. -- I don't have to force any compilers. Are you running the MacPorts' git devel branch?? |
Thanks for following that up. As I have no testing capabilities on PowerPC, I leave it up to you. |
|
{{{ $ uname -a $ port info openblas Description: OpenBLAS is an optimized BLAS library based on GotoBLAS2 Build Dependencies: cctools, gcc6, clang-7.0 |
I have no special globally configured variants or compilers or other settings. I follow MP git master, and mostly install my own devel ports for testing / verification. |
My guess is something might have changed in MP git master then. We can see when you push this -- if the 10.5 PPC buildbot builds it, then we'll know there's an issue in MP git master. |
sounds good. I'm going to go ahead & merge then. |
the buildbot picked gcc6 as well, so it must be something in base in git master we need to tweak. Goes without saying that at this point in time base should never be suggesting any clang compiler for PPC. |
These patches and the small change to force a newer
make
on Tiger fix the build of OpenBLAS on PowerPC macs.It looks like these changes are acceptable to upstream, and these patches should be integrated into the next release of OpenBLAS.
PowerPC forever!