Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-sip: various fixes and tweaks for correctness and brevity #3854

Merged
merged 1 commit into from Mar 15, 2019

Conversation

michaelld
Copy link
Contributor

Closes: https://trac.macports.org/ticket/58195

Description

various fixes and tweaks for correctness and brevity, including the sipdir & other fixes.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.3 18D109
Xcode 10.1 10B61

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@michaelld michaelld requested a review from Veence March 13, 2019 21:24
@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port type: bugfix labels Mar 13, 2019
@michaelld
Copy link
Contributor Author

@Veence Please test / verify for PyQt5. It works for me on 10.14, but more testing is good. I'll also do some testing on older OSs tomorrow.

@macportsbot
Copy link

Travis Build #5585 Passed.

Lint results
--->  Verifying Portfile for py-sip
--->  0 errors and 0 warnings found.

Port py27-sip success on xcode10.2. Log
Port py-sip success on xcode10.2. Log
Port py34-sip success on xcode10.2. Log
Port py35-sip success on xcode10.2. Log
Port py36-sip success on xcode10.2. Log
Port py37-sip success on xcode10.2. Log
Port py27-sip success on xcode9.4. Log
Port py-sip success on xcode9.4. Log
Port py34-sip success on xcode9.4. Log
Port py35-sip success on xcode9.4. Log
Port py36-sip success on xcode9.4. Log
Port py37-sip success on xcode9.4. Log
Port py27-sip success on xcode8.3. Log
Port py-sip success on xcode8.3. Log
Port py34-sip success on xcode8.3. Log
Port py35-sip success on xcode8.3. Log
Port py36-sip success on xcode8.3. Log
Port py27-sip success on xcode7.3. Log
Port py-sip success on xcode7.3. Log
Port py34-sip success on xcode7.3. Log
Port py35-sip success on xcode7.3. Log
Port py36-sip success on xcode7.3. Log
Port py37-sip success on xcode7.3. Log

@Veence
Copy link
Member

Veence commented Mar 14, 2019

@Veence Please test / verify for PyQt5. It works for me on 10.14, but more testing is good. I'll also do some testing on older OSs tomorrow.

Seems to work for me. Go ahead, thanks :)

@michaelld
Copy link
Contributor Author

I can't find a downside to this change, so I'm going ahead and merging.

@michaelld michaelld merged commit 5ff8747 into macports:master Mar 15, 2019
@michaelld michaelld deleted the fixup_sip_4.19.14_0 branch March 15, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: bugfix
3 participants