Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk: Bump version and prefer system deps where possible #3874

Merged
merged 1 commit into from Mar 29, 2019

Conversation

rdbisme
Copy link
Contributor

@rdbisme rdbisme commented Mar 17, 2019

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@stromnov for port vtk.

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 17, 2019

I was encountering a problem with the compiling of mpi4pywith the shipped version from VTK and python37. So I configured the build system to use system libraries wherever possible. This solves the problem.

In particular libharu, libproj4, gls2p have unreleased commit in the vtk-shipped version and so they need to be compiled from sources.

I also bumped the version.

graphics/vtk/Portfile Outdated Show resolved Hide resolved
@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 17, 2019

Moreover I don't think we should force the python variant.

@macportsbot
Copy link

Travis Build #5649 Failed.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

Port vtk fail on xcode10.2. Log
Port vtk fail on xcode9.4. Log
Port vtk fail on xcode8.3. Log

@mf2k
Copy link
Contributor

mf2k commented Mar 17, 2019

Error seems to be:

CMake Error at /opt/local/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find TIFF (missing: TIFF_LIBRARY) (found version "4.0.8")
Call Stack (most recent call first):
  /opt/local/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /opt/local/share/cmake-3.14/Modules/FindTIFF.cmake:70 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMake/vtkModuleMacros.cmake:950 (find_package)
  ThirdParty/tiff/CMakeLists.txt:1 (vtk_module_third_party)

@macportsbot
Copy link

Travis Build #5651 Failed.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

Port vtk fail on xcode10.2. Log
Port vtk fail on xcode9.4. Log
Port vtk fail on xcode8.3. Log

@macportsbot
Copy link

Travis Build #5652 Errored.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

The build timed out.

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 18, 2019

I think it should be ok now. One of the build just timed out.

@macportsbot
Copy link

Travis Build #5702 Errored.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

The build timed out.

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 22, 2019

Ping? :)

graphics/vtk/Portfile Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #5764 Passed.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

Port vtk success on xcode10.2. Log
Port vtk success on xcode9.4. Log
Port vtk success on xcode8.3. Log
Port vtk success on xcode7.3. Log

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 27, 2019

I think now it should be ok! :)

@cjones051073
Copy link
Member

@rubendibattista Your last commit does not follow the commit guidelines. can you either squash it into the first, or update the comment to follow the required portname: comment pattern ?

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 28, 2019

Sorry! :). Rebased...

@macportsbot
Copy link

Travis Build #5808 Errored.

Lint results
--->  Verifying Portfile for vtk
--->  0 errors and 0 warnings found.

Port vtk success on xcode9.4. Log
Port vtk success on xcode7.3. Log

The build timed out.

@cjones051073
Copy link
Member

LGTM

@cjones051073 cjones051073 merged commit 16fa972 into macports:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 participants