php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP #3887

kirmorozov · 2019-03-19T00:41:35Z

Description

MySQL X DevAPI for PHP
Here is how test it

php -r '$session = \mysql_xdevapi\getSession("mysqlx://root:123123qa@127.0.0.1"); print_r($session->getSchemas());'

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.14.3 18D109
Xcode 10.1 10B61

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac 58210 with full URL?

checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2019-03-19T01:20:45Z

Travis Build #5671 Failed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi fail on xcode10.2. Log
Port php-mysql-xdevapi's dependencies fail on xcode10.2. Log
Port php71-mysql-xdevapi fail on xcode10.2. Log
Port php72-mysql-xdevapi fail on xcode10.2. Log
Port php73-mysql-xdevapi fail on xcode9.4. Log
Port php-mysql-xdevapi's dependencies fail on xcode9.4. Log
Port php71-mysql-xdevapi fail on xcode9.4. Log
Port php72-mysql-xdevapi fail on xcode9.4. Log
Port php73-mysql-xdevapi fail on xcode8.3. Log
Port php-mysql-xdevapi's dependencies fail on xcode8.3. Log
Port php71-mysql-xdevapi fail on xcode8.3. Log
Port php72-mysql-xdevapi fail on xcode8.3. Log
Port php73-mysql-xdevapi fail on xcode7.3. Log
Port php-mysql-xdevapi's dependencies fail on xcode7.3. Log
Port php71-mysql-xdevapi fail on xcode7.3. Log

mf2k · 2019-03-19T02:01:32Z

php/php-mysql-xdevapi/Portfile

+long_description        The X DevAPI is the new common API for MySQL Connectors built on the X Protocol introduced in MySQL 5.7.12.
+
+depends_build-append    port:boost
+depends_lib-append      port:boost


The depends_build-append line can be removed because it is included in depends_lib-append.

I was not sure which once to include and how, I manages to build it from sources manually other day.

Fixed Protobuf, building now.

Latest changes are below.
https://github.com/macports/macports-ports/compare/b6e9c98cb4e629453b685525529adf4c01bca7be..a750bb075c2bf21772ba75cf2535702c2dc8a6ef

@mf2k Apparently. php extension keep dynamic link to protobuf3.
Can you give a hint how to build it static, and remove dependencies if binary is installed?

I'm not understanding what you are asking. We don't normally like static builds. We also don't generally work with non Macports dependencies. So adding a dependency on protobuf3-cpp is correct.

mf2k · 2019-03-19T02:01:50Z

php/php-mysql-xdevapi/Portfile

+set cap_name            mysql_xdevapi
+categories-append       net devel
+platforms               darwin freebsd openbsd
+maintainers             {ryandesign @ryandesign} openmaintainer


Since Ryan is being added as maintainer, I want him to approve this.

@ryandesign Keeps eye on php, so put him here also.

Changed to nomaintainer

macportsbot · 2019-03-19T03:45:37Z

Travis Build #5673 Failed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi fail on xcode10.2. Log
Port php-mysql-xdevapi's dependencies fail on xcode10.2. Log
Port php71-mysql-xdevapi fail on xcode10.2. Log
Port php72-mysql-xdevapi fail on xcode10.2. Log
Port php73-mysql-xdevapi fail on xcode9.4. Log
Port php-mysql-xdevapi's dependencies fail on xcode9.4. Log
Port php71-mysql-xdevapi fail on xcode9.4. Log
Port php72-mysql-xdevapi fail on xcode9.4. Log
Port php73-mysql-xdevapi success on xcode8.3. Log
Port php-mysql-xdevapi success on xcode8.3. Log
Port php71-mysql-xdevapi success on xcode8.3. Log
Port php73-mysql-xdevapi success on xcode7.3. Log
Port php-mysql-xdevapi success on xcode7.3. Log
Port php71-mysql-xdevapi success on xcode7.3. Log
Port php72-mysql-xdevapi success on xcode7.3. Log

macportsbot · 2019-03-19T04:40:38Z

Travis Build #5674 Passed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi success on xcode10.2. Log
Port php-mysql-xdevapi success on xcode10.2. Log
Port php71-mysql-xdevapi success on xcode10.2. Log
Port php72-mysql-xdevapi success on xcode10.2. Log
Port php73-mysql-xdevapi success on xcode9.4. Log
Port php-mysql-xdevapi success on xcode9.4. Log
Port php71-mysql-xdevapi success on xcode9.4. Log
Port php72-mysql-xdevapi success on xcode9.4. Log
Port php73-mysql-xdevapi success on xcode8.3. Log
Port php-mysql-xdevapi success on xcode8.3. Log
Port php71-mysql-xdevapi success on xcode8.3. Log
Port php73-mysql-xdevapi success on xcode7.3. Log
Port php-mysql-xdevapi success on xcode7.3. Log
Port php71-mysql-xdevapi success on xcode7.3. Log
Port php72-mysql-xdevapi success on xcode7.3. Log

macportsbot · 2019-03-19T05:35:31Z

Travis Build #5675 Passed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi success on xcode10.2. Log
Port php-mysql-xdevapi success on xcode10.2. Log
Port php71-mysql-xdevapi success on xcode10.2. Log
Port php72-mysql-xdevapi success on xcode10.2. Log
Port php73-mysql-xdevapi success on xcode9.4. Log
Port php-mysql-xdevapi success on xcode9.4. Log
Port php71-mysql-xdevapi success on xcode9.4. Log
Port php72-mysql-xdevapi success on xcode9.4. Log
Port php73-mysql-xdevapi success on xcode8.3. Log
Port php-mysql-xdevapi success on xcode8.3. Log
Port php71-mysql-xdevapi success on xcode8.3. Log
Port php72-mysql-xdevapi success on xcode8.3. Log
Port php73-mysql-xdevapi success on xcode7.3. Log
Port php-mysql-xdevapi success on xcode7.3. Log
Port php71-mysql-xdevapi success on xcode7.3. Log
Port php72-mysql-xdevapi success on xcode7.3. Log

mf2k · 2019-03-19T12:53:35Z

This looks OK but I'm not committing until Ryan approves being maintainer. I'm OK with removing him as maintainer and committing however.

pmetzger · 2019-03-28T19:04:49Z

@kirmorozov ?

mf2k · 2019-03-29T18:53:08Z

It is @ryandesign that I am waiting for to approve/commit this.

kirmorozov · 2019-04-11T17:07:20Z

Hi, I set nomaintainer as maintainer.

macportsbot · 2019-04-11T18:05:46Z

Travis Build #5949 Passed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi success on xcode10.2. Log
Port php-mysql-xdevapi success on xcode10.2. Log
Port php71-mysql-xdevapi success on xcode10.2. Log
Port php72-mysql-xdevapi success on xcode10.2. Log
Port php73-mysql-xdevapi success on xcode9.4. Log
Port php-mysql-xdevapi success on xcode9.4. Log
Port php71-mysql-xdevapi success on xcode9.4. Log
Port php72-mysql-xdevapi success on xcode9.4. Log
Port php73-mysql-xdevapi success on xcode8.3. Log
Port php-mysql-xdevapi success on xcode8.3. Log
Port php71-mysql-xdevapi success on xcode8.3. Log
Port php72-mysql-xdevapi success on xcode8.3. Log
Port php73-mysql-xdevapi success on xcode7.3. Log
Port php-mysql-xdevapi success on xcode7.3. Log
Port php71-mysql-xdevapi success on xcode7.3. Log
Port php72-mysql-xdevapi success on xcode7.3. Log

mf2k · 2019-04-11T18:10:03Z

It looks like there are conflicts that need to be resolved now.

macportsbot · 2019-04-12T19:17:52Z

Travis Build #5964 Passed.

Lint results

--->  Verifying Portfile for php-mysql-xdevapi
--->  0 errors and 0 warnings found.

Port php73-mysql-xdevapi success on xcode10.2. Log
Port php-mysql-xdevapi success on xcode10.2. Log
Port php71-mysql-xdevapi success on xcode10.2. Log
Port php72-mysql-xdevapi success on xcode10.2. Log
Port php73-mysql-xdevapi success on xcode9.4. Log
Port php-mysql-xdevapi success on xcode9.4. Log
Port php71-mysql-xdevapi success on xcode9.4. Log
Port php72-mysql-xdevapi success on xcode9.4. Log
Port php73-mysql-xdevapi success on xcode8.3. Log
Port php-mysql-xdevapi success on xcode8.3. Log
Port php71-mysql-xdevapi success on xcode8.3. Log
Port php72-mysql-xdevapi success on xcode8.3. Log
Port php73-mysql-xdevapi success on xcode7.3. Log
Port php-mysql-xdevapi success on xcode7.3. Log
Port php71-mysql-xdevapi success on xcode7.3. Log
Port php72-mysql-xdevapi success on xcode7.3. Log

pmetzger · 2019-04-13T00:59:29Z

@mf2k No more conflicts. Should we merge?

kirmorozov · 2019-04-29T20:30:48Z

I'm using port locally anyway this one comes handy if someone wants to use Mysql as object storage.

pmetzger · 2019-04-29T20:36:58Z

@mf2k ?

macportsbot added type: enhancement type: submission labels Mar 19, 2019

kirmorozov force-pushed the php-mysql-xdevapi-8.0.15 branch from 2181b90 to b6e9c98 Compare March 19, 2019 00:50

mf2k requested changes Mar 19, 2019

View reviewed changes

mf2k assigned ryandesign Mar 19, 2019

kirmorozov force-pushed the php-mysql-xdevapi-8.0.15 branch from b6e9c98 to a750bb0 Compare March 19, 2019 03:19

kirmorozov force-pushed the php-mysql-xdevapi-8.0.15 branch from a750bb0 to 7e81fb7 Compare March 19, 2019 04:02

mf2k approved these changes Mar 19, 2019

View reviewed changes

php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP

17abe99

kirmorozov force-pushed the php-mysql-xdevapi-8.0.15 branch from 225e0bf to 17abe99 Compare April 12, 2019 18:18

mf2k merged commit 809abed into macports:master Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP #3887

php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP #3887

kirmorozov commented Mar 19, 2019 •

edited

macportsbot commented Mar 19, 2019

mf2k Mar 19, 2019

kirmorozov Mar 19, 2019

kirmorozov Mar 19, 2019

kirmorozov Mar 19, 2019

kirmorozov Mar 19, 2019

mf2k Mar 19, 2019

mf2k Mar 19, 2019

kirmorozov Mar 19, 2019

kirmorozov Apr 11, 2019

macportsbot commented Mar 19, 2019

macportsbot commented Mar 19, 2019

macportsbot commented Mar 19, 2019

mf2k commented Mar 19, 2019

pmetzger commented Mar 28, 2019

mf2k commented Mar 29, 2019

kirmorozov commented Apr 11, 2019

macportsbot commented Apr 11, 2019

mf2k commented Apr 11, 2019

macportsbot commented Apr 12, 2019

pmetzger commented Apr 13, 2019

kirmorozov commented Apr 29, 2019

pmetzger commented Apr 29, 2019

php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP #3887

php-mysql-xdevapi: Adding new Pecl extension MySQL X DevAPI for PHP #3887

Conversation

kirmorozov commented Mar 19, 2019 • edited

Description

Type(s)

Tested on

Verification

macportsbot commented Mar 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macportsbot commented Mar 19, 2019

macportsbot commented Mar 19, 2019

macportsbot commented Mar 19, 2019

mf2k commented Mar 19, 2019

pmetzger commented Mar 28, 2019

mf2k commented Mar 29, 2019

kirmorozov commented Apr 11, 2019

macportsbot commented Apr 11, 2019

mf2k commented Apr 11, 2019

macportsbot commented Apr 12, 2019

pmetzger commented Apr 13, 2019

kirmorozov commented Apr 29, 2019

pmetzger commented Apr 29, 2019

kirmorozov commented Mar 19, 2019 •

edited