py-pyqt5 and py-spyder[-devel]

[reneeotten]

Description

The latest py-pyqt5 release does no longer include PyQtWebEngine and, therefore, the webengine variant doesn't do anything anymore. This causes issue with py-spyder[-devel] that require this variant.

As discussed in ticket 58237, this PR adds the py-pyqt5-webengine subport to py-pyqt5, removes the no-longer-existing configure arguments, and obsoletes the webengine variant.

Finally, the py-spyder[-devel] ports are updated so that they now depend on the new py-pyqt5-webengine port. The additional benefit is that ports providing Spyder do not rely on non-default variants anymore, which should allow them to finish in CI runs and to build on the buildbot.

@mamoll for your consideration/testing; @mf2k this should fix your Spyder issues.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.14.3 18D109
Xcode 10.2 10E125

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@mamoll for port py-pyqt5.

[mamoll]

👍 looks good to me.

[macportsbot]

Travis Build #5776 Errored.

Lint results

--->  Verifying Portfile for py-pyqt5
Error: Line 79 repeats inclusion of PortGroup qmake5
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder
--->  0 errors and 0 warnings found.

The build timed out.

[macportsbot]

Travis Build #5777 Errored.

Lint results

--->  Verifying Portfile for py-pyqt5
Error: Line 79 repeats inclusion of PortGroup qmake5
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder
--->  0 errors and 0 warnings found.

Port py27-pyqt5's dependencies fail on xcode8.3. Log

The build timed out.

[mf2k]

The revision should stay at 0 because you are adding a new port, not actually changing an existing port. There is need for people to rebuild py-pyqt5.

[reneeotten]

I was initially planning on changing the webengine variant to install the py-pyqt5-webengine port, but that resulted in a circular dependency (or something) and didn't work. Right now, you're right that it doesn't need a revision increase; will change that.

[reneeotten]

thanks @mamoll for the response, that is true indeed! I have just updated the PR so that it doesn't increase the revision of py-pyqt5 and with that I think this should be all set!

[macportsbot]

Travis Build #5797 Errored.

Lint results

--->  Verifying Portfile for py-pyqt5
Error: Line 79 repeats inclusion of PortGroup qmake5
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-spyder
--->  0 errors and 0 warnings found.

Port py27-pyqt5's dependencies fail on xcode7.3. Log

The build timed out.