splash: update to v2.9.0

[danieljprice]

• update to version 2.9.0

Closes: https://trac.macports.org/attachment/ticket/58301/

Description

I submitted the trac ticket first, but then read that pull requests are preferred. Hence my first attempt, this one should be straightforward.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.14.4
Xcode 10.2

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Travis Build #5878 Failed.

Lint results

--->  Verifying Portfile for splash
--->  0 errors and 0 warnings found.

Port splash's dependencies fail on xcode10.2. Log
Port splash success on xcode9.4. Log
Port splash success on xcode8.3. Log

[cjones051073]

@danieljprice can you please address @mf2k ‘s comments, thanks ?

[macportsbot]

Travis Build #5916 Failed.

Lint results

--->  Verifying Portfile for splash
--->  0 errors and 0 warnings found.

Port splash success on xcode10.2. Log
Port splash success on xcode9.4. Log
Port splash's dependencies fail on xcode8.3. Log

[cjones051073]

Thanks for adding size, but please follow our commit guidelines. You need to squash those two commits into one, and make sure the commit message follows the portname: explanation pattern.

[cjones051073]

Ping @danieljprice . Can you address the comments please ?

[macportsbot]

Travis Build #5979 Failed.

Lint results

--->  Verifying Portfile for splash
--->  0 errors and 0 warnings found.

Port splash's dependencies fail on xcode10.2. Log
Port splash success on xcode9.4. Log
Port splash success on xcode8.3. Log

[macportsbot]

Travis Build #5980 Passed.

Lint results

--->  Verifying Portfile for splash
--->  0 errors and 0 warnings found.

Port splash success on xcode10.2. Log
Port splash success on xcode9.4. Log
Port splash success on xcode8.3. Log

[cjones051073]

The PR still has two commits in it, one of which is now a merge commit, which means you did not properly rebase your changes before the last push. can you please address this ? This PR needs to show only one commit, your required changes, before it can be merged.

[cjones051073]

I have manually squashed and merged this PR myself.