New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libuv: bump older systems to 1.29.1 #4433
Conversation
Notifying maintainers: |
Tiger? That's commitment. |
I'm not completely sure I have those defines just right in that GNUC/pragma stuff. We want those pragmas active for clang, as I presume that's why they are there. Also, the MINGW stuff can be left out. The close$NOCANCEL$UNIX2003 business seems to compile and link on 10.5+, but failed on 10.4. I don't really know how to rigorously test that, but I think that is working OK. |
When I was updating libuv recently, I thought about rearranging the Portfile to have just the release & devel, and then clauses specific for each group of OSs already represented. I decided against it because it seems like libuv needs to be tested with each release and devel commit for compatibility with these older OSs ... and, looks like I was correct this time (¿yay me?)! |
I'll add a note to test these changes out at work tomorrow on some of my build computers including my fresh & new 10.4 PPC boot! |
Travis Build #6607 Passed. Lint results
Port libuv success on xcode10.2. Log |
add patch for older gcc versions to not error on pragmas add patch for 32bit code to link correctly add bypass path for Tiger, that doesn't seem to have a non-cancellable close function available closes: https://trac.macports.org/ticket/58507
I tweaked it a bit -- I think this is more like what we need. |
Travis Build #6608 Passed. Lint results
Port libuv success on xcode10.2. Log |
see also libuv/libuv#2309 for part of the PR (thought I would got at it bit by bit there) |
Trying this on 10.4 PPC right now. Has to update |
I have a feeling I might be able to improve Tiger by making it do the linux thing
but I'm not sure it's worth the spaghetti code... |
This builds nicely on 10.4 PPC. Let me try on 10.5. |
Plenty of "make check" errors, but whatever it does build! |
Worked on 10.5 Intel too. Same "make check" errors; same-same all around. I'm good with this if you are @kencu . |
Interestingly, the compile does have a few warnings (I think just 3), which look easy to fix & would be upstream-able. |
Sure, I think it's good to go. I don't know if we'll ever squash all the make check and compile warnings, but pretty functional I believe. |
Upstream has set 10.7 as their focus point, but if I'm gentle and don't make too much pasta of their code, they'll accept small fixes that make our life easier on this end. |
add patch for older gcc versions to not error on pragmas
add patch for 32bit code to link correctly
add bypass path for Tiger, that doesn't seem to have
a non-cancellable close function available
closes: https://trac.macports.org/ticket/58507