Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cctools: Allow multiple MacPorts clang versions to satisfy 'as', decouple from llvm variant version. #4472

Merged
merged 3 commits into from May 31, 2019

Conversation

cjones051073
Copy link
Member

Description

cctools : Update logic to select macports clang to be used by 'as' at runtime, to be a list of possible clang versions, independent of the llvm variant cctools is built with. cctools/as will at runtime search these in order and use the first it finds. If none is found, /usr/bin/clang is then used.

gcc9/gcc10: Remove logic used to determine cctools variant used, as no longer needed given above.

Closes: https://trac.macports.org/ticket/58493

Type(s)
  • enhancement
Tested on

Multiple macOS version (10.14, 10.11, 10.9).

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@jeremyhu for port cctools.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement labels May 25, 2019
@macportsbot
Copy link

Travis Build #6659 Errored.

Lint results
--->  Verifying Portfile for cctools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gcc10
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gcc9
--->  0 errors and 0 warnings found.

Port cctools success on xcode10.2. Log
Port cctools success on xcode9.4. Log
Port cctools success on xcode8.3. Log
Port cctools success on xcode7.3. Log

The build timed out.

@cjones051073 cjones051073 requested a review from kencu May 27, 2019 09:37
@cjones051073
Copy link
Member Author

Will give this a few more days, and then unless i have comments to the contrary will merge.

@cjones051073 cjones051073 merged commit 6102af8 into macports:master May 31, 2019
@cjones051073 cjones051073 deleted the cctools-as-clangs branch May 31, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
3 participants