Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clamav-server: Update Portfile with major upgrade, enhancements, and bugfixes #4587

Merged
merged 1 commit into from Jun 22, 2019
Merged

clamav-server: Update Portfile with major upgrade, enhancements, and bugfixes #4587

merged 1 commit into from Jun 22, 2019

Conversation

essandess
Copy link
Contributor

@essandess essandess commented Jun 11, 2019 •
edited

clamav-server: Update Portfile with major upgrade, enhancements, and bugfixes

  • Complete re-write of Portfile
  • Control clamd and freshclam with startupitem, daemondo
  • macOS-specific clamd.conf and freshclam.conf configurations
  • Add Scan-On-Demand bash script with corresponding Finder.app contextual
    menu item
  • Add Scan-On-Schedule launchdaemon with environment variable control
  • Add Scan-On-Access launchdaemon for ~/Downloads and ~/Desktop directories
  • Volunteer as manintainer

Closes: https://trac.macports.org/ticket/58003
Closes: https://trac.macports.org/ticket/50570

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.5 18F132
Xcode 10.2.1 10E1001

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Travis Build #6852 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
Error: Line 68 hardcodes /opt/local, use ${prefix} instead
Error: Line 72 hardcodes /opt/local, use ${prefix} instead
--->  2 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log
Port clamav-server success on xcode7.3. Log

l2dy
l2dy reviewed Jun 12, 2019
View reviewed changes
sysutils/clamav-server/Portfile Outdated Show resolved Hide resolved
sysutils/clamav-server/Portfile Outdated Show resolved Hide resolved
@essandess essandess force-pushed the clamav-server branch 2 times, most recently from 6b13e8d to 1a5c38c Compare June 12, 2019 09:27
@macportsbot
Copy link

Travis Build #6856 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
Error: Line 68 hardcodes /opt/local, use ${prefix} instead
Error: Line 72 hardcodes /opt/local, use ${prefix} instead
--->  2 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log
Port clamav-server success on xcode7.3. Log

@macportsbot
Copy link

Travis Build #6868 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
Error: Line 68 hardcodes /opt/local, use ${prefix} instead
Error: Line 72 hardcodes /opt/local, use ${prefix} instead
--->  2 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log
Port clamav-server success on xcode7.3. Log

@l2dy
Copy link
Member

l2dy commented Jun 13, 2019

Travis Build #6868 Passed.
Lint results

--->  Verifying Portfile for clamav-server
Error: Line 68 hardcodes /opt/local, use ${prefix} instead
Error: Line 72 hardcodes /opt/local, use ${prefix} instead
--->  2 errors and 0 warnings found.

Please fix the hardcoded prefixes.

@essandess
Copy link
Contributor Author

@l2dy Whoops. Thanks. Fixed.

@essandess essandess force-pushed the clamav-server branch 2 times, most recently from c19d56c to 25b049c Compare June 13, 2019 08:18
@macportsbot
Copy link

Travis Build #6876 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
--->  0 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log

@macportsbot
Copy link

Travis Build #6878 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
--->  0 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log

@l2dy
Copy link
Member

l2dy commented Jun 13, 2019

Which files do sysutils/clamav-server/files/LICENSE cover? Could you replace the LICENSE file with a NOTICE stating the licenses involved?

@essandess
Copy link
Contributor Author

Thanks. LICENSE replaced with NOTICE.

@macportsbot
Copy link

Travis Build #6880 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
--->  0 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log

@macportsbot
Copy link

Travis Build #6881 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
--->  0 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode7.3. Log

l2dy
l2dy approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@l2dy l2dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However this is a big update so I would wait for more reviews before merging.

mf2k
mf2k requested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@mf2k mf2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me!

sysutils/clamav-server/Portfile Outdated Show resolved Hide resolved
@essandess
clamav-server: Update Portfile with major upgrade, enhancements, and …
bb7174f 
…bugfixes

* Complete re-write of Portfile
* Control clamd and freshclam with startupitem, daemondo
* macOS-specific clamd.conf and freshclam.conf configurations
* Add Scan-On-Demand bash script with corresponding Finder.app contextual
  menu item
* Add Scan-On-Schedule launchdaemon with environment variable control
* Add Scan-On-Access launchdaemon for ~/Downloads and ~/Desktop directories
* Volunteer as manintainer

Closes: https://trac.macports.org/ticket/58003
Closes: https://trac.macports.org/ticket/50570
@macportsbot
Copy link

Travis Build #6966 Passed.

Lint results 
--->  Verifying Portfile for clamav-server
--->  0 errors and 0 warnings found.

Port clamav-server success on xcode10.2. Log
Port clamav-server success on xcode9.4. Log
Port clamav-server success on xcode8.3. Log

@mf2k mf2k merged commit d0f1e46 into macports:master Jun 22, 2019
@mf2k
Copy link
Contributor

mf2k commented Jun 22, 2019

Thank you!

@essandess essandess deleted the clamav-server branch June 22, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2k mf2k mf2k requested changes

@l2dy l2dy l2dy approved these changes

Assignees
No one assigned
Labels
maintainer: none type: bugfix type: enhancement type: security fix type: update
Milestone
No milestone
4 participants
@essandess @macportsbot @l2dy @mf2k