Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch cclient to work with OpenSSL v1.1 #5366

Merged
merged 1 commit into from Sep 25, 2019
Merged

Patch cclient to work with OpenSSL v1.1 #5366

merged 1 commit into from Sep 25, 2019

Conversation

chrisminett
Copy link
Contributor

Apply FreeBSD patch from https://bugs.freebsd.org/bugzilla/attachment.cgi?id=198493&action=edit
Closes https://trac.macports.org/ticket/58973

An alternative approach might be to switch dependency to openssl10 to avoid the breaking changes, but that's only LTS until 2019-12-31 so would not be suitable in the long term. (v1.1 is LTS to 2023-09-11)

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.6 18G95
Xcode 10.3 10G8

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Travis Build #8403 Passed.

Lint results 
--->  Verifying Portfile for cclient
--->  0 errors and 0 warnings found.

Port cclient success on xcode10.3. Log
Port cclient success on xcode9.4. Log
Port cclient success on xcode8.3. Log
Port cclient success on xcode7.3. Log

@mf2k
Copy link
Contributor

mf2k commented Sep 24, 2019

Per our guidelines, the commit message should be changed to start with the port name:

cclient: Patch to work with OpenSSL v1.1

@chrisminett
Copy link
Contributor Author

Per our guidelines, the commit message should be changed to start with the port name:

cclient: Patch to work with OpenSSL v1.1

Commit message updated.

@macportsbot
Copy link

Travis Build #8409 Passed.

Lint results 
--->  Verifying Portfile for cclient
--->  0 errors and 0 warnings found.

Port cclient success on xcode10.3. Log
Port cclient success on xcode9.4. Log
Port cclient success on xcode8.3. Log
Port cclient success on xcode7.3. Log

mf2k
mf2k requested changes Sep 24, 2019
View reviewed changes
mail/cclient/Portfile Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #8412 Passed.

Lint results 
--->  Verifying Portfile for cclient
--->  0 errors and 0 warnings found.

Port cclient success on xcode10.3. Log
Port cclient success on xcode9.4. Log
Port cclient success on xcode8.3. Log
Port cclient success on xcode7.3. Log

@mf2k mf2k merged commit c0359f0 into macports:master Sep 25, 2019
@chrisminett chrisminett deleted the cclient-openssl_1_1 branch October 22, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2k mf2k mf2k approved these changes

Assignees
No one assigned
Labels
maintainer: none type: bugfix
Milestone
No milestone
3 participants
@chrisminett @macportsbot @mf2k