Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add a GitHub Actions workflow #5510

Closed
wants to merge 3 commits into from
Closed

Conversation

l2dy
Copy link
Member

@l2dy l2dy commented Oct 14, 2019

Description

WIP: We are working on dropping the pastebin requirement.

@l2dy l2dy added the wip Work in progress label Oct 14, 2019
@macportsbot macportsbot added the by: member Created by a member with commit rights label Oct 14, 2019
@l2dy l2dy force-pushed the actions branch 2 times, most recently from 1ecda66 to fc337f2 Compare October 14, 2019 10:12
@macportsbot
Copy link

Travis Build #8654 Passed.

Lint results
--->  Verifying Portfile for asciidoctor
--->  0 errors and 0 warnings found.

Port asciidoctor success on xcode10.3. Log
Port asciidoctor success on xcode9.4. Log
Port asciidoctor success on xcode8.3. Log
Port asciidoctor success on xcode7.3. Log

@pmetzger
Copy link
Member

You seem to have accidentally included a change to asciidoctor along with your proposed addition of the Github CI.

BTW, I'd propose that if we add the Github CI, that we end use of Travis at some point. It doesn't consistently work anyway; it's just a distraction.

@mojca
Copy link
Member

mojca commented Oct 14, 2019

Github CI is probably not that much different from Azure, but yes, Travis is kind of getting too annoying to be useful.

@l2dy
Copy link
Member Author

l2dy commented Oct 14, 2019

You seem to have accidentally included a change to asciidoctor along with your proposed addition of the Github CI.

It was there to test the pull request :)

@pmetzger
Copy link
Member

@l2dy Ah. I didn't realize. It had seemed like an accident.

@markemer
Copy link
Member

Yeah, Travis always fails. I rarely pay attention to it, and it makes every PR present with a red X.

@markemer
Copy link
Member

I was able to Github CI working pretty well, actually - I did some weird stuff like building base, but I think it should be reasonable to do.

@pmetzger
Copy link
Member

pmetzger commented Feb 4, 2020

@l2dy Any status on this?

@l2dy
Copy link
Member Author

l2dy commented Feb 4, 2020

@l2dy Any status on this?

I need to set the paste URL to https://paste.z0k.xyz/ to get logs uploaded.

But I'm not sure if we really need GitHub Actions, we have Azure Pipelines which is basically the same infrastructure with different APIs. GitHub Actions has native integration with the GitHub web interface though.

@pmetzger
Copy link
Member

pmetzger commented Feb 4, 2020

I would say that we should get rid of Travis and maybe switch over to GitHub actions? Though I'm not sure about the latter. Dumping Travis seems like a good move, though. It no longer adds value.

@pmetzger
Copy link
Member

pmetzger commented Feb 4, 2020

Either way, though, we should put this PR to bed...

@kencu
Copy link
Contributor

kencu commented Apr 17, 2020

I'm looking to kill off ancient PRs that aren't going anywhere -- is this one?

@l2dy
Copy link
Member Author

l2dy commented Apr 17, 2020

I'll check if Azure Pipelines provides a better API now. If it does, we can switch to it and abandon both Travis CI and GitHub Actions.

@l2dy
Copy link
Member Author

l2dy commented Apr 26, 2020

We could use artifacts to store logs, which would remove the need for a pastebin. https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts

@mojca
Copy link
Member

mojca commented Apr 26, 2020

I would be in favour of adding support for github actions if we already have the code, even if it duplicates azure. If we can avoid pastebin, the benefit is even bigger. We can later decide to drop azure if results end up being the same.

@l2dy l2dy force-pushed the actions branch 2 times, most recently from 6eaa346 to 53d4511 Compare September 8, 2020 17:33
@macportsbot
Copy link

Travis Build #13875 Passed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

@macportsbot
Copy link

Travis Build #13877 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13878 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13880 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13881 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13882 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@macportsbot
Copy link

Travis Build #13883 Failed.

Lint results
--->  Verifying Portfile for wtf
--->  0 errors and 0 warnings found.

Port wtf fail on xcode10.3. Log
Port wtf fail on xcode9.4. Log
Port wtf fail on xcode8.3. Log
Port wtf fail on xcode7.3. Log

@l2dy
Copy link
Member Author

l2dy commented Sep 8, 2020

Merged as db7b40d.

@l2dy l2dy closed this Sep 8, 2020
@l2dy l2dy deleted the actions branch October 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights wip Work in progress
6 participants