-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: Add a GitHub Actions workflow #5510
Conversation
1ecda66
to
fc337f2
Compare
Travis Build #8654 Passed. Lint results
Port asciidoctor success on xcode10.3. Log |
You seem to have accidentally included a change to BTW, I'd propose that if we add the Github CI, that we end use of Travis at some point. It doesn't consistently work anyway; it's just a distraction. |
Github CI is probably not that much different from Azure, but yes, Travis is kind of getting too annoying to be useful. |
It was there to test the pull request :) |
@l2dy Ah. I didn't realize. It had seemed like an accident. |
Yeah, Travis always fails. I rarely pay attention to it, and it makes every PR present with a red X. |
I was able to Github CI working pretty well, actually - I did some weird stuff like building base, but I think it should be reasonable to do. |
@l2dy Any status on this? |
I need to set the paste URL to https://paste.z0k.xyz/ to get logs uploaded. But I'm not sure if we really need GitHub Actions, we have Azure Pipelines which is basically the same infrastructure with different APIs. GitHub Actions has native integration with the GitHub web interface though. |
I would say that we should get rid of Travis and maybe switch over to GitHub actions? Though I'm not sure about the latter. Dumping Travis seems like a good move, though. It no longer adds value. |
Either way, though, we should put this PR to bed... |
I'm looking to kill off ancient PRs that aren't going anywhere -- is this one? |
I'll check if Azure Pipelines provides a better API now. If it does, we can switch to it and abandon both Travis CI and GitHub Actions. |
We could use artifacts to store logs, which would remove the need for a pastebin. https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts |
I would be in favour of adding support for github actions if we already have the code, even if it duplicates azure. If we can avoid pastebin, the benefit is even bigger. We can later decide to drop azure if results end up being the same. |
6eaa346
to
53d4511
Compare
Travis Build #13875 Passed. Lint results
|
Travis Build #13877 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Travis Build #13878 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Travis Build #13880 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Travis Build #13881 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Travis Build #13882 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Travis Build #13883 Failed. Lint results
Port wtf fail on xcode10.3. Log |
Merged as db7b40d. |
Description
WIP: We are working on dropping the pastebin requirement.