gmt5: update gmt6 sub-port to version 6.0.0

[seisman]

Description

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.14.6 18G95
Xcode 10.3 10G8

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@tenomoto for port gmt5.

[macportsbot]

Travis Build #8982 Passed.

Lint results

--->  Verifying Portfile for gmt5
--->  0 errors and 0 warnings found.

Port gmt5 success on xcode10.3. Log
Port gmt6 success on xcode10.3. Log
Port gmt5 success on xcode9.4. Log
Port gmt6 success on xcode9.4. Log
Port gmt5 success on xcode8.3. Log
Port gmt6 success on xcode8.3. Log
Port gmt5 success on xcode7.3. Log

[seisman]

This PR is ready for review. Can anyone help review and merge it?

[remkos]

The new version 6 of GMT also looks for ghostscript, ffmpeg and graphicsmagick during the cmake configuration.

• ghostscript is needed in any case during runtime, so it is better to add that as a dependency.
• ffmpeg and graphicsmagick are only used during runtime to make movies or animations, so it is not essential to have those. Because there is a check at runtime whether either is available, there is no risk of having it been found during configuration and not at runtime.

Can you at least add -DGS_ROOT=${prefix} in case of gmt6 (gmt5 does not have this)?

Furthermore, the cmake configuration has a tendency to mix the library and include files for curl between the system and macports, respectively, which of course is unwanted. I came across this with Fink (fink/fink-distributions#493). This can be prevented using:
-DCURL_INCLUDE_DIR=${prefix}/include
-DCURL_LIBRARY=${prefix}/lib/libcurl.dylib
In addition, curl should be added as a dependency.

[remkos]

@seisman, if you can make the suggested updates, I can (probably) approve.

[seisman]

• ghostscript is needed in any case during runtime, so it is better to add that as a dependency.

ghostscript is already in the list of depends_lib.

Can you at least add -DGS_ROOT=${prefix} in case of gmt6 (gmt5 does not have this)?

Added for gmt6.

Furthermore, the cmake configuration has a tendency to mix the library and include files for curl between the system and macports, respectively, which of course is unwanted. I came across this with Fink (fink/fink-distributions#493). This can be prevented using:
-DCURL_INCLUDE_DIR=${prefix}/include
-DCURL_LIBRARY=${prefix}/lib/libcurl.dylib
In addition, curl should be added as a dependency.

curl is added to depends_lib. I think -DCURL_ROOT is enough, right?

[macportsbot]

Travis Build #9069 Errored.

Lint results

--->  Verifying Portfile for gmt5
--->  0 errors and 0 warnings found.

Port gmt5 success on xcode10.3. Log
Port gmt5 success on xcode9.4. Log
Port gmt6 success on xcode9.4. Log
Port gmt5 success on xcode8.3. Log
Port gmt6 success on xcode8.3. Log
Port gmt5 success on xcode7.3. Log

The build timed out.

[macportsbot]

Travis Build #9077 Failed.

Lint results

--->  Verifying Portfile for gmt5
--->  0 errors and 0 warnings found.

Port gmt5 success on xcode10.3. Log
Port gmt6 success on xcode10.3. Log
Port gmt5 success on xcode9.4. Log
Port gmt6 fail on xcode9.4. Log
Port gmt5's dependencies fail on xcode8.3. Log
Port gmt6 success on xcode8.3. Log
Port gmt5 success on xcode7.3. Log
Port gmt6 success on xcode7.3. Log

[remkos]

Thanks for making those changes.
It seems like it works fine with -DCURL_ROOT=${prefix}.
Approved.

[mf2k]

The commit message should be:

gmt5: update gmt6 sub-port to version 6.0.0

[seisman]

@mf2k Thanks for your review. I've addressed your comments and fixed the commit message.

[macportsbot]

Travis Build #9093 Failed.

Lint results

--->  Verifying Portfile for gmt5
--->  0 errors and 0 warnings found.

Port gmt5 success on xcode10.3. Log
Port gmt6 success on xcode10.3. Log
Port gmt5's dependencies fail on xcode9.4. Log
Port gmt6 success on xcode9.4. Log
Port gmt5 success on xcode8.3. Log
Port gmt6 success on xcode8.3. Log
Port gmt5 success on xcode7.3. Log
Port gmt6 success on xcode7.3. Log

[mf2k]

While this LGTM, this port is not openmaintainer so I want to give @tenomoto more time to look at this.

[seisman]

@mf2k It's been two days. Could you merge it?

[cjones051073]

Looks fine to me. Merging under maintainer timeout.