Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt4-mac: allow newer compilers on older systems #5747

Merged
merged 3 commits into from Nov 10, 2019

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8
Xcode 3.2.6

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@michaelld for port qt4-mac.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels Nov 9, 2019
@michaelld
Copy link
Contributor

Lawd have mercy ... more qt4-mac patches!

@michaelld
Copy link
Contributor

So do I read this correctly that we're trying to build Qt4 here with C/C++98 unless C++11 is specified? Meaning we specifically tell the compiler the standard to use, all of the time ... trying to avoid using more recent C/C++ standards so-as to avoid the pitfalls of them on such old code?

@kencu
Copy link
Contributor

kencu commented Nov 9, 2019

that would appear to work so long as some qt4 dep doesn't go all c++11-only on us...

@macportsbot
Copy link

Travis Build #9125 Errored.

Lint results
--->  Verifying Portfile for qt4-mac
--->  0 errors and 0 warnings found.

Port qt4-mac fail on xcode9.4. Log

The build timed out.

@MarcusCalhoun-Lopez
Copy link
Contributor Author

So do I read this correctly that we're trying to build Qt4 here with C/C++98 unless C++11 is specified? Meaning we specifically tell the compiler the standard to use, all of the time ... trying to avoid using more recent C/C++ standards so-as to avoid the pitfalls of them on such old code?

Yes, that is the idea.
I have not tested it, but it may be possible to override the override if a port requires both Qt4 and C++11.

Lawd have mercy ... more qt4-mac patches!

Sorry.
I could not think of another way to proceed.

@kencu
Copy link
Contributor

kencu commented Nov 9, 2019

I have it building away on 10.6.8 32bit version using clang-9.0 against libc++. will report back in a few hours when it's done.

Copy link
Contributor

@kencu kencu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, on 10.6.8 building with clang-9.0.

I had to rebuild the qt4-mac-sqlite3-plugin from source for some reason, as it was not found when I installed the binary. I don't know exactly if that was something real or gremlins, but otherwise it built and the software runs.

on 10.5 leopard I am getting segfaults trying to open qt4 applications now, but that is a separate issue.

@michaelld
Copy link
Contributor

michaelld commented Nov 10, 2019

@kencu It looks like this change doesn't impact 10.13 or 10.14, so there's a good change it'll work with 10.15 as well. If it allows qt4-mac build on older OSX with more modern compilers, then I'm good with it. I honestly don't think I'll have time to test / verify this coming week. Hence, if you think this change is ready, then go ahead and merge. Thx!

@kencu kencu merged commit 532963a into macports:master Nov 10, 2019
@MarcusCalhoun-Lopez MarcusCalhoun-Lopez deleted the qt4-mac_fix branch December 14, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
4 participants