New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt4-mac: allow newer compilers on older systems #5747
Conversation
Notifying maintainers: |
Lawd have mercy ... more qt4-mac patches! |
So do I read this correctly that we're trying to build Qt4 here with C/C++98 unless C++11 is specified? Meaning we specifically tell the compiler the standard to use, all of the time ... trying to avoid using more recent C/C++ standards so-as to avoid the pitfalls of them on such old code? |
that would appear to work so long as some qt4 dep doesn't go all c++11-only on us... |
Travis Build #9125 Errored. Lint results
Port qt4-mac fail on xcode9.4. Log The build timed out. |
Yes, that is the idea.
Sorry. |
I have it building away on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works, on 10.6.8 building with clang-9.0.
I had to rebuild the qt4-mac-sqlite3-plugin from source for some reason, as it was not found when I installed the binary. I don't know exactly if that was something real or gremlins, but otherwise it built and the software runs.
on 10.5 leopard I am getting segfaults trying to open qt4 applications now, but that is a separate issue.
@kencu It looks like this change doesn't impact 10.13 or 10.14, so there's a good change it'll work with 10.15 as well. If it allows qt4-mac build on older OSX with more modern compilers, then I'm good with it. I honestly don't think I'll have time to test / verify this coming week. Hence, if you think this change is ready, then go ahead and merge. Thx! |
Description
Type(s)
Tested on
macOS 10.6.8
Xcode 3.2.6
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?