Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmt5, gmt6: use github for tarball and livecheck #6154

Merged
merged 1 commit into from Jan 24, 2020
Merged

gmt5, gmt6: use github for tarball and livecheck #6154

merged 1 commit into from Jan 24, 2020

Conversation

remkos
Copy link
Contributor

@remkos remkos commented Jan 14, 2020

Description

This makes livecheck on gmt5 and gmt6 work and en passant changes to getting the tarball from github

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.2
Xcode Command Line tools 10.3

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@tenomoto for port gmt5.

science/gmt5/Portfile Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #9985 Errored.

Lint results
--->  Verifying Portfile for gmt5
--->  0 errors and 0 warnings found.

Port gmt5 success on xcode10.3. Log
Port gmt5 success on xcode9.4. Log
Port gmt6 success on xcode9.4. Log
Port gmt5 success on xcode8.3. Log
Port gmt6 success on xcode8.3. Log
Port gmt5 success on xcode7.3. Log
Port gmt6 success on xcode7.3. Log

The build timed out.

@remkos remkos requested a review from mf2k January 15, 2020 09:11
@g5pw
Copy link
Contributor

g5pw commented Jan 24, 2020

This looks fine. Thanks for your contribution to MacPorts, @remkos, and sorry for the delay in merging this. Pinging macports-dev is the way to go if things get a little backed up.

@g5pw g5pw merged commit 33ae0ef into macports:master Jan 24, 2020
@remkos remkos deleted the gmt-livecheck-update branch January 27, 2020 08:20
@remkos
Copy link
Contributor Author

remkos commented Jan 27, 2020

This looks fine. Thanks for your contribution to MacPorts, @remkos, and sorry for the delay in merging this. Pinging macports-dev is the way to go if things get a little backed up.

Thanks, I'll do so next time.

@g5pw
Copy link
Contributor

g5pw commented Jan 27, 2020

You already did! That's how I got the heads up that this still needed to be merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants