texstudio: Major update and cleanup

[yan12125]

Description

1. Switch to qt5
2. texstudio no longer uses precompile_header, so blacklisting clang is not necessary
3. Use GNU tar to extract the source tarball. BSD tar can't handle 2.16.6 tarballs. 2.16.4 worked fine, so it may change in the future. Fixed upstream

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.12.6
Xcode 8.3.3

Verification

Have you

• followed our Commit Message Guidelines?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL? (N/A)
• checked your Portfile with port lint?
• tried existing tests with sudo port test? (N/A)
• tried a full install with sudo port -vst install?
  It builds yet with quite a few warnings:

Warning: The following files inside the MacPorts prefix not installed by a port were accessed:
  /opt/local/libexec/qt5/include/QtConcurrent/qtconcurrent_global.h
  /opt/local/libexec/qt5/include/QtConcurrent/qtconcurrentcompilertest.h
  /opt/local/libexec/qt5/include/QtConcurrent/qtconcurrentrunbase.h
  /opt/local/libexec/qt5/include/QtConcurrent/qtconcurrentstoredfunctioncall.h

/opt/local/libexec/qt5/include/QtConcurrent symlinks to ../lib/QtConcurrent.framework/Headers, and /opt/local/libexec/qt5/lib/QtConcurrent.framework/Headers is part of qt5-qtbase, so I guess those warnings are harmless.

• tested basic functionality of all binary files?

By the way, may I become the maintainer of this package? I expect I'll use it for at least a few more years.

[yan12125]

Hmm there's a bug - upstream tarball does not include Info.plist, so the built texstudio.app does not have an icon. Let me report it to upstream.

UPDATE: reported as https://sourceforge.net/p/texstudio/bugs/2231/

[yan12125]

The missing Info.plist bug is fixed upstream. The 3rd point in the original is no longer valid, either - the new tarball can be extracted by BSD tar.

[drkp]

Thanks! I've also added you as maintainer of this port, and set the openmaintainer policy so others can update it as well (let me know if you want to change that.)

[yan12125]

Thanks! Here's a question - is maintainer info maintained elsewhere? It's still "nomaintainer" in the latest Portfile.

[drkp]

Nope, just forgot to push.

[yan12125]

Thanks. That's great!