lout: fix to use MacPorts-selected compiler, and specify compatible compilers #662
Conversation
|
part 1 of a fix for lout failing to run on SIerra. This part fixes the build to use the MacPorts-selected compiler. |
|
Travis built the 10.10 and 10.11 versions OK -- those clangs appear to work, but 10.12's clang does not. |
|
here are the compiler test results on Sierra: /usr/bin/clang FAIL |
| @@ -1,4 +1,5 @@ | |||
| PortSystem 1.0 | |||
| PortGroup compiler_blacklist_versions 1.0 | |||
There was a problem hiding this comment.
You're not using this portgroup. But you should use it, to blacklist specific versions of Xcode clang, such as compiler.blacklist-append {clang >= 802 < 900} (replace these version numbers with the actual version numbers that are affected by this bug). This should be done outside of any platform-version-specific block, assuming it would affect those versions of Xcode clang on any systems where they work.
There was a problem hiding this comment.
Can do it that way. XCode clang 703.0.31 built it OK. xcode clang 802.0.42 did not.
We don't yet know the number of the clang in the future that might work to build it again, we blacklist all clangs > 800. Once xcode 9 comes out, we can check again to see if there's an upper bound.
textproc/lout/Portfile
Outdated
| # see <https://github.com/macports/macports-ports/pull/662> | ||
| compiler.blacklist-append {macports-clang-3.[0-9]} clang | ||
| compiler.fallback-append {macports-clang-4.0} {macports-clang-5.0} | ||
| } |
There was a problem hiding this comment.
There is no reason to enclose plain compiler names inside curly brackets, such as on the fallback line. (I see why you're doing so on the blacklist line, though, to prevent Tcl from interpreting the square brackets.)
kencu
changed the title
|
@ryandesign -- I think everyone is leaving this to you given your requested changes (done). |
|
No revbump as Port either built correctly or not at all |
Description
Type(s)
Tested on
macOS 10.12
Xcode 8.3.3
Verification
Have you
port lint?sudo port test?sudo port -vst install?