Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsch: update to 0.1.55 #6632

Merged
merged 1 commit into from Mar 31, 2020
Merged

jsch: update to 0.1.55 #6632

merged 1 commit into from Mar 31, 2020

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Mar 19, 2020 •
edited

Use Java portgroup + LTS OpenJDK fallback instead of kaffe (deprecated)
See https://trac.macports.org/ticket/60206

Add size to checksums

Description

See upstream changelog: http://www.jcraft.com/jsch/ChangeLog

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Untested.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@chicagotripp for port jsch.

chrstphrchvz
chrstphrchvz commented Mar 19, 2020
View reviewed changes
java/jsch/Portfile

depends_lib bin:java:kaffe
java.version 1.7+
java.fallback openjdk8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback is a MacPorts-provided Java that is installed when an existing Java (version 7 or higher) installation isn't already present on the system. I have specified an LTS OpenJDK version for the fallback, however since I do not know if JSch is compatible with Java 11, I have specified OpenJDK 8 to be less disruptive. However OpenJDK 11 (the more recent LTS version) would be preferred if this port is known to work fine it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, are you testing whether the port works with OpenJDK 11 or is this ready to merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can test this anytime soon. If the maintainer has nothing to say, then I guess this is ready to merge.

@macportsbot
Copy link

Travis Build #10796 Passed.

Lint results 
--->  Verifying Portfile for jsch
--->  0 errors and 0 warnings found.

Port jsch success on xcode10.3. Log
Port jsch success on xcode9.4. Log
Port jsch success on xcode8.3. Log

@chrstphrchvz chrstphrchvz marked this pull request as ready for review March 19, 2020 14:18
@chrstphrchvz
jsch: update to 0.1.55
37123e5 
Use Java portgroup + LTS OpenJDK fallback
instead of kaffe (deprecated)
See: https://trac.macports.org/ticket/60206

Add size to checksums
@macportsbot
Copy link

Travis Build #10814 Passed.

Lint results 
--->  Verifying Portfile for jsch
--->  0 errors and 0 warnings found.

Port jsch success on xcode10.3. Log
Port jsch success on xcode9.4. Log
Port jsch success on xcode8.3. Log

@reneeotten reneeotten merged commit cfaa086 into macports:master Mar 31, 2020
@chrstphrchvz chrstphrchvz deleted the patch-8 branch March 31, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten left review comments

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port type: bugfix type: enhancement type: update
Milestone
No milestone
3 participants
@chrstphrchvz @macportsbot @reneeotten