softhsm: update to 2.6.0 and make compatible with latest compiler

[iay]

Description

Two changes:

• update to latest upstream release
• patch that to compile under latest macOS/Xcode, see https://trac.macports.org/ticket/60235

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.15.4 19E266
Xcode 11.4 11E146

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
  • (two separate changes for same port, related but not identical)
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
  • Error: Failed to test softhsm: softhsm has no tests turned on. see 'test.run' in portfile(7)
  • I have run the package's internal checks, though: make check
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@Jakker for port softhsm.

[macportsbot]

Travis Build #10902 Passed.

Lint results

--->  Verifying Portfile for softhsm
--->  0 errors and 0 warnings found.

Port softhsm success on xcode10.3. Log
Port softhsm success on xcode9.4. Log
Port softhsm success on xcode8.3. Log
Port softhsm success on xcode7.3. Log

[mf2k]

LGTM. But please change:

See https://trac.macports.org/ticket/60235

To:

Fixes: https://trac.macports.org/ticket/60235

In the 2nd commit message to actually close the Trac ticket.

[iay]

Rebased against master again, changed commit comment as requested.

[macportsbot]

Travis Build #10910 Passed.

Lint results

--->  Verifying Portfile for softhsm
--->  0 errors and 0 warnings found.

Port softhsm success on xcode10.3. Log
Port softhsm success on xcode9.4. Log
Port softhsm success on xcode8.3. Log
Port softhsm success on xcode7.3. Log

[iay]

I'm not sure what to make of those test failures as all I did was change a comment since the last tests ran OK. I did find this by following some links through to the CI site:

On March 23, 2020, Azure Pipelines will remove Windows Server 2012 R2 with Visual Studio 2015(vs2015-win2012r2), macOS High Sierra 10.13 (macOS-10.13), and Windows Server Core 1803 (win1803) from our hosted pools. This includes builds using the Hosted agent pool. A series of brownouts to highlight builds and releases using these soon-to-be-removed images will be conducted over the next couple of weeks. During these brownouts, any builds and releases using the vs2015-win2012r2, macOS-10.13, or win1803 images will fail.

Related?

[reneeotten]

@Jakker are you happy with and approve these changes?

[Jakker]

@Jakker are you happy with and approve these changes?

Yes I do.

It would be nice if someone else could take over the maintenance of this, since I clearly don't have the time to keep up.

[iay]

It would be nice if someone else could take over the maintenance of this, since I clearly don't have the time to keep up.

@Jakker: I don't know if this is the place to have that discussion, but I'd be prepared to help out with that. The provisos are that it's 20 years since I last did anything serious with C++, know none of the internals of this application and am only a recent user of it. I will have an ongoing need for it for the next year or so at a minimum, though, so keeping the port up to date with new versions shouldn't be a problem.

[Jakker]

@iay: I'm not a user of the port on MacOsX myself so that is another reason I'm slow in updating this. I think you'll be fine taking this over. The hefty lifting is (fixing bugs etc.) is mostly done by the upstream.

[iay]

I'm not a user of the port on MacOsX myself so that is another reason I'm slow in updating this. I think you'll be fine taking this over. The hefty lifting is (fixing bugs etc.) is mostly done by the upstream.

OK, that makes sense, particularly if you're not actually the port yourself. I'll spin up a patch to add myself as a maintainer. I saw something in the Guide about doing that.

Do you want to be removed entirely, or can you stay as backup?

[Jakker]

Do you want to be removed entirely, or can you stay as backup?

I can stay as a backup, no problem.