Update of Port ehcache to version 3.8.1 #6784

saptarshi1729 · 2020-04-03T19:37:51Z

Resolution of issue #60219 - [https://trac.macports.org/ticket/60219]

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.15.3 19D76

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2020-04-03T19:57:45Z

Travis Build #11028 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log
Port ehcache fail on xcode7.3. Log

ryandesign · 2020-04-04T22:41:56Z

The homepage is wrong. Use PortGroup github 1.0 and github.setup ehcache ehcache3 3.8.1 v and github.tarball_from releases which will set homepage, master_sites, name, version, livecheck for you.

The log of the build failure says:

Error: Failed to destroot ehcache: xinstall: Cannot stat: /opt/local/var/macports/build/_Users_runner_runners_2.165.2_work_1_s_java_ehcache/ehcache/work/ehcache/build/dist/ehcache-3.8.1.jar, No such file or directory

Since you're now downloading a prebuilt jar rather than building it, you'd need to change ${worksrcpath}/build/dist/${name}-${version}.jar to ${distpath}/${files}.

The log also says:

--->  Extracting ehcache-3.8.1.jar
...
gzip: /opt/local/var/macports/distfiles/ehcache/ehcache-3.8.1.jar: not in gzip format

Since you don't want MacPorts to try to extract this file you should add the line extract.only (to indicate that MacPorts should "only" extract none of the distfiles).

Probably should add supported_archs noarch.

worksrcdir should be removed.

ryandesign · 2020-04-04T22:42:43Z

Oh, and add Closes: https://trac.macports.org/ticket/60219 to the commit message (on a line by itself with a blank line above it).

macportsbot · 2020-04-05T07:49:22Z

Travis Build #11040 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log

macportsbot · 2020-04-05T07:56:05Z

Travis Build #11041 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log

macportsbot · 2020-04-05T08:04:55Z

Travis Build #11042 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log

ryandesign · 2020-04-05T09:16:46Z

${distpath}/${files}

Oh whoops I meant ${distpath}/${distfiles}

macportsbot · 2020-04-05T10:18:42Z

Travis Build #11043 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log

macportsbot · 2020-04-05T10:46:12Z

Travis Build #11044 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log

JacksonIsaac · 2020-04-05T11:38:17Z

The homepage is wrong. Use PortGroup github 1.0 and github.setup ehcache ehcache3 3.8.1 v and github.tarball_from releases which will set homepage, master_sites, name, version, livecheck for you.

Here's an example to use github Portgroup:

https://github.com/macports/macports-ports/blob/master/devel/libsolv/Portfile#L7

macportsbot · 2020-04-05T12:09:18Z

Travis Build #11045 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log

macportsbot · 2020-04-05T12:15:27Z

Travis Build #11046 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log

macportsbot · 2020-04-06T06:33:11Z

Travis Build #11058 Failed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache fail on xcode10.3. Log
Port ehcache fail on xcode9.4. Log
Port ehcache fail on xcode8.3. Log
Port ehcache fail on xcode7.3. Log

ryandesign · 2020-04-06T10:32:22Z

I didn't notice that there is a difference between the desired port name "ehcache" and the github repository name "ehcache3" so yes you do need to override the github portgroup's default name with name ehcache as you did.

It's failing to fetch because the github portgroup overrides the default for distname. Usually this is helpful, but in the case of this port it's unfortunately counterproductive, so you'll need to override distname again with distname ${name}-${version}.

macportsbot · 2020-04-06T15:06:36Z

Travis Build #11061 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

macportsbot · 2020-04-06T16:01:17Z

Travis Build #11062 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

mojca

Please follow commit message guidelines (you have the link in the PR template).

mojca · 2020-04-06T16:16:23Z

java/ehcache/Portfile


 categories			java
 maintainers			nomaintainer
 platforms			darwin
+license				Apache-2


Please make sure that you use consistent whitespacing (spaces only, no tabs, align to 20 spaces) throughout the file. If the original uses tabs, create a separate commit that first fixes whitespacing, and then another commit with functional changes.

Hi, Thanks for the suggestions. I'll rectify it soon.

Hi, I've added the whitespaces, but the resulting alignment doesn't seem to serve the purpose. You may kindly find the same in my commit and revert. I'm trying out a way of ensuring a fine alignment. Any advice in this regard is always highly appreciated.

You need to use spaces instead of tabs.

Hi, Thanks to both @mojca and @mf2k for pointing it out. I've corrected and incorporated the spacing, hopefully as required. Please revert in case of any issue.

mojca · 2020-04-06T16:18:03Z

java/ehcache/Portfile

-
-depends_build		bin:ant:apache-ant
-depends_lib			bin:java:kaffe
+checksums			md5 a6f66597f5aca8104972a79e72d62a04 \


Do you really need md5? It's not strictly deprecated. If the upstream publishes md5 it may be kept.

Following the other existing portfiles, I had wished to retain it. I may remove it, may please let me know if required.

macportsbot · 2020-04-06T17:33:34Z

Travis Build #11064 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

macportsbot · 2020-04-07T03:10:26Z

Travis Build #11072 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log

macportsbot · 2020-04-07T04:06:33Z

Travis Build #11073 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

mf2k · 2020-04-07T07:51:52Z

java/ehcache/Portfile

+                        1.  Fast \
+                        2.  Simple \
+                        3.  Acts as a pluggable cache for Hibernate \
+                        4.  Small foot print. Both in terms of size and memory requirements. \
+                        5.  Minimal dependencies. \
+                        6.  Fully documented. See the online Documentation, FAQ and the online JavaDoc. \
+                        7.  Comprehensively Test Coverage. See the clover test report. \
+                        8.  Scalable to hundreds of caches and large multi-cpu servers. \
+                        9.  Provides LRU, LFU and FIFO cache eviction policies. \
+                        10. Available under the Apache 1.1 license. Ehcache's copyright and licensing has been reviewed and approved by the Apache Software Foundation, making ehcache suitable for use in Apache projects. \
+                        11. Production tested. All final versions of ehcache are production tested for several weeks on a large and very busy eCommerce site before release.


Your lines are too long here. First, start at four spaces out and for the lines that are still past column 80, wrap them to the next line.

mf2k · 2020-04-07T07:53:11Z

java/ehcache/Portfile

+    xinstall -m 644 \
+        ${distpath}/${distfiles} \
+        ${distpath}


This is normally all on the same line. Don't wrap it to make 3 lines.

mojca

Please squash the commits and fix the commit message according to the guidelines.

mojca · 2020-04-07T08:46:32Z

java/ehcache/Portfile

@@ -1,53 +1,54 @@
 PortSystem 1.0


Now that you fixed the spacing: check other ports which contain some special commented-out settings in the first line and copy-paste that one here.

Hi, I've added the same.

mojca

Please read again through the Commit Message Guidelines.

macportsbot · 2020-04-07T11:23:36Z

Travis Build #11076 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log

macportsbot · 2020-04-07T12:12:47Z

Travis Build #11077 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

saptarshi1729 · 2020-04-07T13:52:20Z

Please read again through the Commit Message Guidelines.

Hi, I've gone through the same and have incorporated changes. Kindly see.

mf2k · 2020-04-07T15:35:05Z

java/ehcache/Portfile

+                        following features: \
+                        1.  Fast \
+                        2.  Simple \
+                        3.  Acts as a pluggable cache for Hibernate \
+                        4.  Small foot print. Both in terms of size and memory \
+                        requirements. \
+                        5.  Minimal dependencies. \
+                        6.  Fully documented. See the online Documentation, FAQ \
+                        and the online JavaDoc. \
+                        7.  Comprehensively Test Coverage. See the clover test \
+                        report. \
+                        8.  Scalable to hundreds of caches and large multi-cpu \
+                        servers. \
+                        9.  Provides LRU, LFU and FIFO cache eviction policies. \
+                        10. Available under the Apache 1.1 license. Ehcache's \
+                        copyright and licensing has been reviewed and approved \
+                        by the Apache Software Foundation, making ehcache \
+                        suitable for use in Apache projects. \
+                        11. Production tested. All final versions of ehcache \
+                        are production tested for several weeks on a large and \
+                        very busy eCommerce site before release.


You are wasting too much space here. Move these lines left to start at column 4. Then you can re-wrap out to column 80. Then it won't be using as many lines. Does that make sense?

Hi Sir,
I've made the change accordingly. Please review my latest commit. Thanks.

macportsbot · 2020-04-07T15:59:26Z

Travis Build #11079 Passed.

Lint results

--->  Verifying Portfile for ehcache
--->  0 errors and 0 warnings found.

Port ehcache success on xcode10.3. Log
Port ehcache success on xcode9.4. Log
Port ehcache success on xcode8.3. Log
Port ehcache success on xcode7.3. Log

mf2k · 2020-04-07T17:39:40Z

java/ehcache/Portfile

+
+description             Ehcache is a pure Java, in-process object cache.
+long_description        Ehcache is a pure Java, in-process cache with the \
+                        following features: \


Almost there. This one (1) line should be moved left to column 4 also.

I've done the same, Sir. May please review it. Thanks.

* update to version 3.8.1 * removing dependency on deprecated port kaffe * introducing dependency on Java portgroup * rectifying alignment and spacing Closes: https://trac.macports.org/ticket/60219

macportsbot added maintainer: none type: enhancement type: update labels Apr 3, 2020

saptarshi1729 force-pushed the newbranch4 branch from 87a312d to 2306eaf Compare April 5, 2020 10:39

saptarshi1729 force-pushed the newbranch4 branch from 2306eaf to 3abcb85 Compare April 5, 2020 12:01

saptarshi1729 force-pushed the newbranch4 branch from 5db218d to 72597e8 Compare April 6, 2020 15:31

mojca reviewed Apr 6, 2020

View reviewed changes

saptarshi1729 force-pushed the newbranch4 branch from b0f3b1b to aa8897d Compare April 6, 2020 17:36

mf2k requested changes Apr 7, 2020

View reviewed changes

mojca reviewed Apr 7, 2020

View reviewed changes

saptarshi1729 force-pushed the newbranch4 branch from 3fe3d22 to 03074ec Compare April 7, 2020 10:16

mojca reviewed Apr 7, 2020

View reviewed changes

saptarshi1729 force-pushed the newbranch4 branch from 03074ec to e8b26dc Compare April 7, 2020 12:07

mf2k requested changes Apr 7, 2020

View reviewed changes

saptarshi1729 force-pushed the newbranch4 branch from e8b26dc to 38d69f0 Compare April 7, 2020 15:49

mf2k requested changes Apr 7, 2020

View reviewed changes

ehcache: update to version 3.8.1

bb146af

* update to version 3.8.1 * removing dependency on deprecated port kaffe * introducing dependency on Java portgroup * rectifying alignment and spacing Closes: https://trac.macports.org/ticket/60219

saptarshi1729 force-pushed the newbranch4 branch from 38d69f0 to bb146af Compare April 7, 2020 18:36

mf2k approved these changes Apr 7, 2020

View reviewed changes

JacksonIsaac merged commit 3ae6f98 into macports:master Apr 9, 2020

Update of Port ehcache to version 3.8.1 #6784

Update of Port ehcache to version 3.8.1 #6784

Conversation

saptarshi1729 commented Apr 3, 2020

Type(s)

Tested on

Verification

macportsbot commented Apr 3, 2020

ryandesign commented Apr 4, 2020

ryandesign commented Apr 4, 2020

macportsbot commented Apr 5, 2020

macportsbot commented Apr 5, 2020

macportsbot commented Apr 5, 2020

ryandesign commented Apr 5, 2020 • edited

macportsbot commented Apr 5, 2020

macportsbot commented Apr 5, 2020

JacksonIsaac commented Apr 5, 2020

macportsbot commented Apr 5, 2020

macportsbot commented Apr 5, 2020

macportsbot commented Apr 6, 2020

ryandesign commented Apr 6, 2020

macportsbot commented Apr 6, 2020

macportsbot commented Apr 6, 2020

mojca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saptarshi1729 Apr 6, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macportsbot commented Apr 6, 2020

macportsbot commented Apr 7, 2020

macportsbot commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mojca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mojca left a comment

Choose a reason for hiding this comment

macportsbot commented Apr 7, 2020

macportsbot commented Apr 7, 2020

saptarshi1729 commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macportsbot commented Apr 7, 2020

mf2k Apr 7, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryandesign commented Apr 5, 2020 •

edited

saptarshi1729 Apr 6, 2020 •

edited

mf2k Apr 7, 2020 •

edited