Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: submission turbogit #7213

Merged
merged 1 commit into from
May 31, 2020
Merged

WIP: submission turbogit #7213

merged 1 commit into from
May 31, 2020

Conversation

b4nst
Copy link
Contributor

@b4nst b4nst commented May 24, 2020

Description

Add new port turbogit

Type(s)
  • enhancement
Tested on

macOS 10.14.6 18G4032

Verification

Have you

@macportsbot
Copy link

Travis Build #11814 Passed.

Lint results
--->  Verifying Portfile for turbogit
--->  0 errors and 0 warnings found.

Port turbogit success on xcode10.3. Log
Port turbogit success on xcode9.4. Log
Port turbogit success on xcode8.3. Log
Port turbogit success on xcode7.3. Log

@cjones051073
Copy link
Member

@b4nst many thanks for submission. Just for future reference though its bad practise to use your master branch for a PR, as if you commit anything else to it unrelated it will appear here. In future please fork a feature branch to use for PRs to avoid this.

@b4nst
Copy link
Contributor Author

b4nst commented May 24, 2020

Thanks for your feedback. That makes sense, I will keep that in mind for next time.

Copy link
Member

@cjones051073 cjones051073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port appears to just install a premade binary. We prefer ports to build from source whenever possible, so if this can be done please update this port to do this.

devel/turbogit/Portfile Outdated Show resolved Hide resolved
devel/turbogit/Portfile Outdated Show resolved Hide resolved
@b4nst
Copy link
Contributor Author

b4nst commented May 25, 2020

I need to rework the Makefile and add new asset for it to be build from source. I can do it for next release and update the Portfile then.

@macportsbot
Copy link

Travis Build #11830 Passed.

Lint results
--->  Verifying Portfile for turbogit
--->  0 errors and 0 warnings found.

Port turbogit success on xcode10.3. Log
Port turbogit success on xcode9.4. Log
Port turbogit success on xcode8.3. Log

@b4nst b4nst requested a review from cjones051073 May 25, 2020 16:45
@cjones051073
Copy link
Member

cjones051073 commented May 25, 2020

Can you give any sort of timeline on when the changes needed to build from source might be available ?

@b4nst
Copy link
Contributor Author

b4nst commented May 25, 2020

@cjones051073 Probably one or 2 weeks

@cjones051073
Copy link
Member

Ok. Is there a pressing need for this now, or could it wait until it could be updated to build from source ?

@b4nst
Copy link
Contributor Author

b4nst commented May 26, 2020

Nope, you're right it can wait the next release to be built from source. See you next week! Thanks for all your help/time.

@b4nst b4nst closed this May 26, 2020
@cjones051073
Copy link
Member

Thanks, but there was no need to close this. We should keep it open as WIP, to preserve the discussion, and then when you are ready just force push the new update to the branch here.

@cjones051073 cjones051073 reopened this May 26, 2020
@cjones051073 cjones051073 added the wip Work in progress label May 26, 2020
@cjones051073 cjones051073 changed the title submission turbogit WIP: submission turbogit May 26, 2020
@macportsbot
Copy link

Travis Build #11848 Passed.

Lint results
--->  Verifying Portfile for turbogit
--->  0 errors and 0 warnings found.

Port turbogit success on xcode10.3. Log
Port turbogit success on xcode9.4. Log
Port turbogit success on xcode8.3. Log
Port turbogit success on xcode7.3. Log

@macportsbot
Copy link

Travis Build #11937 Passed.

Lint results
--->  Verifying Portfile for turbogit
--->  0 errors and 0 warnings found.

Port turbogit success on xcode10.3. Log
Port turbogit success on xcode9.4. Log
Port turbogit success on xcode8.3. Log
Port turbogit success on xcode7.3. Log

@b4nst
Copy link
Contributor Author

b4nst commented May 31, 2020

Ok @cjones051073 here is the version built from source.

@cjones051073 cjones051073 merged commit 751f112 into macports:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: submission wip Work in progress
3 participants