-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: submission turbogit #7213
WIP: submission turbogit #7213
Conversation
Travis Build #11814 Passed. Lint results
Port turbogit success on xcode10.3. Log |
@b4nst many thanks for submission. Just for future reference though its bad practise to use your master branch for a PR, as if you commit anything else to it unrelated it will appear here. In future please fork a feature branch to use for PRs to avoid this. |
Thanks for your feedback. That makes sense, I will keep that in mind for next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This port appears to just install a premade binary. We prefer ports to build from source whenever possible, so if this can be done please update this port to do this.
I need to rework the Makefile and add new asset for it to be build from source. I can do it for next release and update the Portfile then. |
Travis Build #11830 Passed. Lint results
Port turbogit success on xcode10.3. Log |
Can you give any sort of timeline on when the changes needed to build from source might be available ? |
@cjones051073 Probably one or 2 weeks |
Ok. Is there a pressing need for this now, or could it wait until it could be updated to build from source ? |
Nope, you're right it can wait the next release to be built from source. See you next week! Thanks for all your help/time. |
Thanks, but there was no need to close this. We should keep it open as WIP, to preserve the discussion, and then when you are ready just force push the new update to the branch here. |
Travis Build #11848 Passed. Lint results
Port turbogit success on xcode10.3. Log |
Travis Build #11937 Passed. Lint results
Port turbogit success on xcode10.3. Log |
Ok @cjones051073 here is the version built from source. |
Description
Add new port turbogit
Type(s)
Tested on
macOS 10.14.6 18G4032
Verification
Have you
port lint
?sudo port -vst install
?