Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-browser-for-sqlite: move symlink creation into post-destroot, add c++11 to build #7217

Merged
merged 2 commits into from May 26, 2020

Conversation

i0ntempest
Copy link
Member

Description

Closes: https://trac.macports.org/ticket/60551
Closes: https://trac.macports.org/ticket/60552

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.4 19E287
Xcode 11.5 11E608c

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Travis Build #11823 Passed.

Lint results
--->  Verifying Portfile for db-browser-for-sqlite
--->  0 errors and 0 warnings found.

Port db-browser-for-sqlite success on xcode10.3. Log
Port db-browser-for-sqlite success on xcode9.4. Log
Port db-browser-for-sqlite success on xcode7.3. Log

Copy link
Member

@cjones051073 cjones051073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. You can remove the line

PortGroup           compiler_blacklist_versions 1.0

as its no longer used.

@cjones051073
Copy link
Member

cjones051073 commented May 25, 2020

The changes here do not I am afraid fix the problems I addressed with the compiler blacklist. See my last comment to https://trac.macports.org/ticket/60552

@i0ntempest i0ntempest changed the title db-browser-for-sqlite: move symlink creation into post-destroot, add -std=c++11 db-browser-for-sqlite: move symlink creation into post-destroot, add c++11 to build May 26, 2020
@macportsbot
Copy link

Travis Build #11843 Failed.

Lint results
--->  Verifying Portfile for db-browser-for-sqlite
--->  0 errors and 0 warnings found.

Port db-browser-for-sqlite success on xcode10.3. Log
Port db-browser-for-sqlite's dependencies fail on xcode9.4. Log
Port db-browser-for-sqlite success on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #11844 Passed.

Lint results
--->  Verifying Portfile for db-browser-for-sqlite
--->  0 errors and 0 warnings found.

Port db-browser-for-sqlite success on xcode10.3. Log
Port db-browser-for-sqlite success on xcode9.4. Log
Port db-browser-for-sqlite success on xcode7.3. Log

The build timed out.

@cjones051073 cjones051073 merged commit a0e2bcb into macports:master May 26, 2020
@cjones051073
Copy link
Member

@i0ntempest
Copy link
Member Author

How?? CI build on 10.11 was successful...

@cjones051073
Copy link
Member

It can happen I am afraid. You'll need to delve into the logs above to figure out how.

@i0ntempest i0ntempest deleted the dbbrowser branch May 27, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants