Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submission vimproc #745

Closed
wants to merge 1 commit into from
Closed

Conversation

krischik
Copy link
Contributor

@krischik krischik commented Sep 5, 2017

Description

vimproc is a great asynchronous execution library for Vim.

Type(s)
  • submission
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.12.6 16G29
Xcode 8.3.3 8E3004b

Verification

Have you

  • [x ] followed our Commit Message Guidelines?

  • checked your Portfile with port lint?
    ---> Verifying Portfile for vimproc
    Warning: no license set
    ---> 0 errors and 1 warnings found.

  • tried existing tests with sudo port test?

  • tried a full install with sudo port -vst install?

  • tested basic functionality of all binary files?

description: vimproc is a great asynchronous execution library for Vim.
@kencu
Copy link
Contributor

kencu commented Sep 19, 2017

If you get a moment, could you clean up the formatting? Tabs should be 4 spaces, everything should line up as per the usual Portfile outline. This will most likely be reviewed by @raimue who seems to do all the MacPorts vim-related things. - Thanks!

@raimue
Copy link
Member

raimue commented Sep 19, 2017

Thank you for the submission. The place for vim plugins would normally be ${prefix}/share/vim/vimfiles/. However, this directory is currently not on the runtimepath of MacVim. Sorry, my fault that I never got back to that ticket.

These days, most people prefer to use vim-specific tools to manage vim plugins in their home (like vim-plug, Vundle, or NeoBundle). Therefore we do not have any other ports installing vim plugins at all. Is it really worth the effort to maintain a port for vimproc?

@pmetzger
Copy link
Member

Do we have a decision on this? The pull request dates to September.

@raimue
Copy link
Member

raimue commented Mar 20, 2018

As there was no more feedback, I am closing this pull request. Unless someone comes up with a good reason for vim plugins or with a policy which vim plugins we should distribute as a port, I think vim plugin managers like vim-plug, Vundle, neobundle.vim, etc. are the better option to handle them.

@raimue raimue closed this Mar 20, 2018
chenguokai pushed a commit to chenguokai/macports-ports that referenced this pull request May 7, 2020
@krischik krischik deleted the Pick8aa6096875 branch November 3, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants