VLC : upgrade to 3.0.11 #7466

RJVB · 2020-06-19T10:19:06Z

VLC : upgrade to 3.0.11

Also makes (lib)VLC and (lib)VLC2 co-installable on systems where
VLC2 is supported, maintaining access to QTKit support where this
is still possible (support was dropped from VLC 3.0.11).
This requires adaptation of port:phonon-backend-vlc, which also got
an upgrade to the latest version instead of a simple revbump.

Closes: https://trac.macports.org/ticket/60667

Type(s)

bugfix
enhancement
security fix

Tested on

OS X 10.9.5

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?

checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

RJVB · 2020-06-19T10:21:44Z

Co-installability also makes testing after upgrades a lot easier for me; in fact, I can now use VLC3 for my phonon backend while still using the VLC2 full app. I didn't think it necessary to put that justification in the commit message :)

macportsbot · 2020-06-19T12:04:33Z

Travis Build #12239 Errored.

Lint results

--->  Verifying Portfile for phonon-backend-vlc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Line 40 repeats inclusion of PortGroup obsolete
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for VLC2
Error: Line 39 repeats inclusion of PortGroup obsolete
Warning: missing recommended checksum type: size
--->  1 errors and 1 warnings found.

The build timed out.

ryandesign

I haven't tried to build this on my own system. Looks like it failed on the CI but the logs have already been deleted.

multimedia/VLC2/Portfile

multimedia/VLC/files/patch-build-on-pre-1012.diff

audio/phonon-backend-vlc/Portfile

RJVB · 2020-06-30T09:10:14Z

I haven't tried to build this on my own system. Looks like it failed on the CI but the logs have already been deleted.

Looked like a timeout to me.

macportsbot · 2020-06-30T12:53:36Z

Travis Build #12446 Errored.

Lint results

--->  Verifying Portfile for phonon-backend-vlc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Line 40 repeats inclusion of PortGroup obsolete
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for VLC2
Error: Line 39 repeats inclusion of PortGroup obsolete
Warning: missing recommended checksum type: size
--->  1 errors and 1 warnings found.

The build timed out.

ryandesign · 2020-06-30T19:59:24Z

multimedia/VLC2/Portfile

-    variant smb description {Enable Samba 3 input support} {
-        depends_lib-append      port:samba3
+    variant smb description {Enable Samba 3+ input support} {
+        depends_lib-append      path:${prefix}/bin/smbclient:samba3
        configure.args-replace  --disable-smbclient --enable-smbclient
        configure.ldflags-append    -L${prefix}/lib/samba3


It's redundant to put ${prefix}/ into that path depspec.

But look below that line where it says -L${prefix}/lib/samba3. That won't work for your proposed samba4 port, will it? If this ends up linking with a samba library, and samba3 and samba4 install them to different locations or names as I hope they do so that they don't conflict, then I assume there will need to be separate samba3 and samba4 variants.

Shoot, I knew that of course. Your other concern is unnecessary. The samba4 port conflicts with samba3, installs its libraries into $prefix/lib/samba and a few additional symlinks in $prefix/lib/samba3 (e.g. for dependents that don't use the pkgconfig files). That directory would be temporary unless there is a need to preserve two samba ports (I haven't run into any ABI compatibility problems IIRC).

I should get back to that project...

The current samba4 port does not declare itself to be conflicting with samba3. But it was last updated over a decade ago and has not been buildable for over 7 years at least, so we can basically consider the port not to exist at all; it's been dead and buried for a long time. Now if you're planning to resurrect samba4 by updating it to a current version that's great, I'm just asking you to ensure that it does not conflict with samba3. It would be unusual for a port named samba4 to install any files in a directory named samba3. If you don't see a need for separate samba3 and samba4 ports, then by all means have just one. At that point, since we would be changing the name away from samba3 regardless, it might make sense to call the new port just "samba". And then there can indeed be just a single samba or smb variant for vlc.

I don't disagree with all that; this change is indeed a temporary compromise that I should probably have kept private. If ever I do get the samba4 port to work sufficiently well all dependents will surely require at least a revbump.

FWIW, I've delved into samba4 because apparently the port:samba3 nor the system smb version can connect to the Win10 computers in the house. I've managed to get v4.8.9 to build following online instructions, and now I can again connect to those computers. Not via the Finder, of course, and only most of the time (sometimes it still just doesn't work). The online instructions also outline how to set up a server, and I haven't yet managed to get that to function. The feature doesn't interest me myself, but others might expect to have it...

ryandesign · 2020-06-30T20:02:35Z

Looked like a timeout to me.

You're looking at the Travis build. We know Travis only gives us 50 minutes of build time and builds often fail for that reason.

I was talking about the Azure builds which have a much larger time limit. Now that you've pushed a new commit and a new build has happened, we can see why the build failed on Azure:

libtool: install: /usr/bin/install -c .libs/vlc-osx /opt/local/bin/vlc-osx
install: /opt/local/bin/vlc-osx: Operation not permitted
make[3]: *** [install-binPROGRAMS] Error 71

RJVB · 2020-07-01T08:37:15Z

Looked like a timeout to me.

You're looking at the Travis build. We know Travis only gives us 50 minutes of build time and builds often fail for that reason.

I was talking about the Azure builds which have a much larger time limit. Now that you've pushed a new commit and a new build has happened, we can see why the build failed on Azure:
libtool: install: /usr/bin/install -c .libs/vlc-osx /opt/local/bin/vlc-osx
install: /opt/local/bin/vlc-osx: Operation not permitted
make[3]: *** [install-binPROGRAMS] Error 71

How can that happen?!

macportsbot · 2020-07-01T11:45:08Z

Travis Build #12474 Errored.

Lint results

--->  Verifying Portfile for phonon-backend-vlc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Line 40 repeats inclusion of PortGroup obsolete
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for VLC2
Error: Line 39 repeats inclusion of PortGroup obsolete
Warning: missing recommended checksum type: size
--->  1 errors and 1 warnings found.

The build timed out.

ryandesign · 2020-07-02T04:01:32Z

How can that happen?!

It looks like everything in the Making install in lib section is fine. The files get installed in the destroot. And then once it gets to the Making install in bin section it has forgotten all about the destroot and tries to install the files directly, which MacPorts doesn't allow. As for why that's happening, I don't know; I've never tried to look at the VLC build system before.

RJVB · 2020-07-02T09:01:28Z

On Wednesday July 01 2020 21:01:44 Ryan Schmidt wrote: tries to install the files directly, which MacPorts doesn't allow. As for why that's happening, I don't know; I've never tried to look at the VLC build system before.

It is not impossible, but that would be new and annoyingly it seems to happen only with the main port. Which I can't build myself... I'll have to compare to the Linux build system, and hope this concerns only vlc_osx (which looks like it could be redundant).

RJVB · 2020-07-02T12:31:33Z

I didn't seek out Chromium's code specifically; that's just what turned up when I Googled CALayerDelegate.

I did too, evidently, if the result you got was among mine it must have been buried or too far down in the list. Go figure why...

Also makes (lib)VLC and (lib)VLC2 co-installable on systems where VLC2 is supported, maintaining access to QTKit support where this is still possible (support was dropped from VLC 3.0.11). This requires adaptation of port:phonon-backend-vlc, which also got an upgrade to the latest version instead of a simple revbump. Closes: https://trac.macports.org/ticket/60667

https: //github.com/macports/macports-ports/pull/7466 Committed from host : Bola

macportsbot · 2020-07-02T19:13:42Z

Travis Build #12506 Errored.

Lint results

--->  Verifying Portfile for phonon-backend-vlc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Line 40 repeats inclusion of PortGroup obsolete
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for VLC2
Error: Line 39 repeats inclusion of PortGroup obsolete
Warning: missing recommended checksum type: size
--->  1 errors and 1 warnings found.

Port phonon-backend-vlc's dependencies fail on xcode8.3. Log

The build timed out.

ryandesign · 2020-07-03T05:15:20Z

the main port. Which I can't build myself...

Why not?

RJVB · 2020-07-03T08:19:10Z

> the main port. Which I can't build myself... Why not?

Because I'm still happily hanging out on 10.9 (I've got my reasons, the fact it's 2011 hardware included :) ) I thought this was a bit of a public secret...

ryandesign · 2020-07-03T08:25:13Z

Because I'm still happily hanging out on 10.9 (I've got my reasons, the fact it's 2011 hardware included :) )

That's fine, I just didn't realize VLC didn't build on 10.9 anymore. Doesn't the port currently say:

VLC 3.0.8 requires Mac OS X 10.9 or greater.

RJVB · 2020-07-03T09:10:40Z

``` VLC 3.0.8 requires Mac OS X 10.9 or greater. ```

Yes, and there's some magic in place to make sure legacy OS users get directed to port:VLC2, and port:VLC2 users get an automatic upgrade to port:VLC after updating their OS. However, the main obstacle that I cannot get around of is the .nib files which are too new. Most other things could probably be worked around like the other workarounds (conditional backports, in the code or through specific patch files). That obstacle doesn't exist for port:libVLC, and that's the reason why I now propose to remove the libVLC ports from the conflicts list, so legacy OS users can have a full, working VLC2 install but also a v3.x libVLC, for instance for their Phonon backend. And *that* I've been able to test (even using libVLC2 for the Qt4 phonon backend and libVLC for the Qt5 one).

kencu · 2020-08-17T03:51:19Z

I used the web editor to resolve the conflict that had developed here. If it is to be committed, it appears that we would need to select "Squash and Merge" to do it properly, FYI.

macportsbot · 2020-08-17T05:31:15Z

Travis Build #13445 Errored.

Lint results

--->  Verifying Portfile for phonon-backend-vlc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Line 40 repeats inclusion of PortGroup obsolete
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for VLC2
Error: Line 39 repeats inclusion of PortGroup obsolete
Warning: missing recommended checksum type: size
--->  1 errors and 1 warnings found.

The build timed out.

RJVB · 2020-08-17T07:24:25Z

Were there open issues left that I've been overlooking?

kencu · 2020-08-17T16:35:26Z

Hi @RJVB -- this seems to fail all the CI builds. You're the maintainer of this, so it's really your call -- but it's hard to commit it as is with all these test builds failing.

RJVB · 2020-08-17T17:26:02Z

As far as I can tell they fail because of a timeout, unambiguously so for Travis, but I can't make anything else of the other one either (it just fails after installing 174 or so dependencies).

kencu · 2020-08-17T18:12:08Z

That is the first time I've done a squash-and-merge. I sincerely hope it worked out the way it was supposed to.

kencu · 2020-08-17T18:13:27Z

Well look at that -- yes it did...

RJVB · 2020-08-17T21:37:53Z

Well look at that -- yes it did...

You could have asked to to take care of it. I usually do that kind of thing simply by recreating the branch and then force-pushing it. I see 2 dependencies fail to install, I presume I can wait for feedback on that from the respective port maintainers?

kencu · 2020-08-17T21:41:22Z

It had been like that a while, and I didn't want to bug you any further than we obviously already had, so I thought I would see if my skill set might be able to fix this... I was happy to see that I could, and it wasn't too hard to do.

I don't know about the deps -- I'll step back into the background now and leave this with you, as you know 100x more about VLC on MacPorts than I will ever know. Thanks for sticking with us :>

macportsbot added maintainer maintainer: open Affects an openmaintainer port labels Jun 19, 2020

RJVB changed the title ~~#### Description~~ VLC : upgrade to 3.0.11 Jun 19, 2020

ryandesign reviewed Jun 30, 2020

View reviewed changes

multimedia/VLC2/Portfile Outdated Show resolved Hide resolved

multimedia/VLC/files/patch-build-on-pre-1012.diff Outdated Show resolved Hide resolved

audio/phonon-backend-vlc/Portfile Outdated Show resolved Hide resolved

RJVB force-pushed the VLC2+3 branch from 54c9300 to 324c789 Compare June 30, 2020 09:10

ryandesign reviewed Jun 30, 2020

View reviewed changes

RJVB force-pushed the VLC2+3 branch from 324c789 to bf5a2c3 Compare July 1, 2020 08:48

RJVB force-pushed the VLC2+3 branch from bf5a2c3 to afabc0c Compare July 2, 2020 12:39

RJVB added a commit to RJVB/macstrop that referenced this pull request Jul 2, 2020

port:VLC* : sync with PR7466

96614eb

https: //github.com/macports/macports-ports/pull/7466 Committed from host : Bola

Merge branch 'master' into VLC2+3

2f944d4

kencu merged commit 8d50572 into macports:master Aug 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VLC : upgrade to 3.0.11 #7466

VLC : upgrade to 3.0.11 #7466

RJVB commented Jun 19, 2020

RJVB commented Jun 19, 2020

macportsbot commented Jun 19, 2020

ryandesign left a comment

RJVB commented Jun 30, 2020

macportsbot commented Jun 30, 2020

ryandesign Jun 30, 2020

RJVB Jul 1, 2020

ryandesign Jul 2, 2020

RJVB Jul 2, 2020

ryandesign commented Jun 30, 2020

RJVB commented Jul 1, 2020

macportsbot commented Jul 1, 2020

ryandesign commented Jul 2, 2020

RJVB commented Jul 2, 2020 via email

RJVB commented Jul 2, 2020 via email

macportsbot commented Jul 2, 2020

ryandesign commented Jul 3, 2020

RJVB commented Jul 3, 2020 via email

ryandesign commented Jul 3, 2020

RJVB commented Jul 3, 2020 via email

kencu commented Aug 17, 2020

macportsbot commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020

kencu commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020

VLC : upgrade to 3.0.11 #7466

VLC : upgrade to 3.0.11 #7466

Conversation

RJVB commented Jun 19, 2020

Type(s)

Tested on

Verification

RJVB commented Jun 19, 2020

macportsbot commented Jun 19, 2020

ryandesign left a comment

Choose a reason for hiding this comment

RJVB commented Jun 30, 2020

macportsbot commented Jun 30, 2020

ryandesign Jun 30, 2020

Choose a reason for hiding this comment

RJVB Jul 1, 2020

Choose a reason for hiding this comment

ryandesign Jul 2, 2020

Choose a reason for hiding this comment

RJVB Jul 2, 2020

Choose a reason for hiding this comment

ryandesign commented Jun 30, 2020

RJVB commented Jul 1, 2020

macportsbot commented Jul 1, 2020

ryandesign commented Jul 2, 2020

RJVB commented Jul 2, 2020 via email

RJVB commented Jul 2, 2020 via email

macportsbot commented Jul 2, 2020

ryandesign commented Jul 3, 2020

RJVB commented Jul 3, 2020 via email

ryandesign commented Jul 3, 2020

RJVB commented Jul 3, 2020 via email

kencu commented Aug 17, 2020

macportsbot commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020

kencu commented Aug 17, 2020

RJVB commented Aug 17, 2020 via email

kencu commented Aug 17, 2020