Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileZilla: update to 3.27.1 #767

Merged
merged 1 commit into from Sep 11, 2017
Merged

FileZilla: update to 3.27.1 #767

merged 1 commit into from Sep 11, 2017

Conversation

yan12125
Copy link
Contributor

Description

Closes: https://trac.macports.org/ticket/53008

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.12.6 16G29
Xcode 8.3.3 8E3004b

Verification

Have you

  • followed our Commit Message Guidelines?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test? (There are no tests)
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

l2dy
l2dy reviewed Sep 11, 2017
View reviewed changes
www/FileZilla/Portfile Outdated
@@ -5,7 +5,7 @@ PortGroup wxWidgets 1.0
PortGroup compiler_blacklist_versions 1.0

name FileZilla
version 3.14.1
version 3.27.1
revision 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear revision.

@yan12125
Copy link
Contributor Author

Please clear revision.

Thanks, updated!

@l2dy l2dy merged commit ff17aaf into macports:master Sep 11, 2017
@l2dy
Copy link
Member

l2dy commented Sep 11, 2017 •
edited

Build failed on OS X <= 10.11. Please update the compiler and stdlib config.

checking for thread_local... no
configure: error: Compiler support for the thread_local keyword is required.

@mojca
Copy link
Member

mojca commented Sep 11, 2017

Please also file a port abandoned ticket and take over the maintainership.

@yan12125 yan12125 mentioned this pull request Sep 12, 2017
Closed
10 tasks
@yan12125
Copy link
Contributor Author

Thanks for the feedback. I created #771 and https://trac.macports.org/ticket/54821, respectively.

@yan12125 yan12125 deleted the update-filezilla branch September 12, 2017 09:40
chenguokai pushed a commit to chenguokai/macports-ports that referenced this pull request May 7, 2020
@bmellstrom @xor-gate
Add support for mass erasing second bank on STM32F10x_XL (macports#767)
8186d85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2dy l2dy l2dy left review comments

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port type: enhancement type: update
Milestone
No milestone
4 participants
@yan12125 @l2dy @mojca @macportsbot