New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria2: appletls is not available on 10.6 or earlier #8
Conversation
|
||
# appletls not available on 10.6 or earlier | ||
platform darwin { | ||
if { ${os.major} <= 10 } { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just use
if {${os.platform} eq "darwin" && ${os.major} <= 10} {
and avoid the excess nesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that! Thanks.
Please commit it as it is and I'll consider larry's changes for the next portfile fix I suggest. |
While I don't object merging this as-is, isn't the point of having pull request reviews that the comments can be fixed before the code is merged? |
Uh, yes. Yes it is. @ken-cunningham-webuse, why don’t you want to make the change? |
I agree with @neverpanic. Please add @larryv's change. |
OK. I found a reference how to do this: http://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request |
Aesthetics are up to the maintainer, who is @Schamschula. You just have to modify your branch; GitHub will pick up the new commits automatically. |
I think that actually worked... |
Looks good. |
This is an example of a pull request that should have been squashed before merging. As a separate commit, without any connection to this pull request, the commit message does not make much sense. |
No description provided.