Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2: appletls is not available on 10.6 or earlier #8

Merged
merged 2 commits into from Nov 2, 2016
Merged

aria2: appletls is not available on 10.6 or earlier #8

merged 2 commits into from Nov 2, 2016

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Nov 2, 2016

No description provided.


# appletls not available on 10.6 or earlier
platform darwin {
if { ${os.major} <= 10 } {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just use

if {${os.platform} eq "darwin" && ${os.major} <= 10} {

and avoid the excess nesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that! Thanks.

@kencu
Copy link
Contributor Author

kencu commented Nov 2, 2016

Please commit it as it is and I'll consider larry's changes for the next portfile fix I suggest.

@neverpanic
Copy link
Member

While I don't object merging this as-is, isn't the point of having pull request reviews that the comments can be fixed before the code is merged?

@larryv
Copy link
Member

larryv commented Nov 2, 2016

Uh, yes. Yes it is. @ken-cunningham-webuse, why don’t you want to make the change?

@Schamschula
Copy link
Contributor

I agree with @neverpanic. Please add @larryv's change.

@kencu
Copy link
Contributor Author

kencu commented Nov 2, 2016

OK. I found a reference how to do this:

http://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request

@larryv
Copy link
Member

larryv commented Nov 2, 2016

Aesthetics are up to the maintainer, who is @Schamschula.

You just have to modify your branch; GitHub will pick up the new commits automatically.

@kencu
Copy link
Contributor Author

kencu commented Nov 2, 2016

I think that actually worked...

@Schamschula
Copy link
Contributor

Looks good.

@Schamschula Schamschula merged commit f1d115c into macports:master Nov 2, 2016
@kencu kencu deleted the patch-1 branch November 2, 2016 16:53
@raimue
Copy link
Member

raimue commented Nov 2, 2016

This is an example of a pull request that should have been squashed before merging. As a separate commit, without any connection to this pull request, the commit message does not make much sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants