unbound: enable support for dnscrypt, dnstap

[iefdev]

Description

• Enable support for dnscrypt, dnstap
• Add variant for dnstap
• Disable dsa

Type(s)

• enhancement

Tested on

macOS 10.7.5 11G63
Xcode 4.6.3 4H1503

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vsd install?

[macportsbot]

Notifying maintainers:
@nerdling for port unbound.

[iefdev]

I would also really like to add this one to: (but…)

if {${os.major} >= 15} {
    configure.args-append   --enable-tfo-client \
                            --enable-tfo-server
}

This enables the support for TCP Fast Open: »»»

macOS have support for that from 10.11. So, before adding anything - someone with 10.11 would have to test that it installs correctly without the error that follows.

Unbound have taken the approach to error the install if not found, instead of looking for it first and skip it. The function is connectx()

If the if-condition works, I guess one could just add it as is now, &/or put it in a variant and mention the 10.11 requirement in the description?

For me it's not so important since I can't use it, but I think most who can would like to have it.

[macportsbot]

Travis Build #13487 Passed.

Lint results

--->  Verifying Portfile for unbound
--->  0 errors and 0 warnings found.

Port unbound success on xcode10.3. Log
Port unbound success on xcode9.4. Log
Port unbound success on xcode8.3. Log
Port unbound success on xcode7.3. Log

[nerdling]

someone with 10.11 would have to test that it installs correctly without the error that follows.

If that's on a branch and the time-to-build isn't egregious, liekly Travis Build here will let you know if it works on 10.11 (xcode 7.3 is run on 10.11 I believe: https://paste.macports.org/6da7256b95d3 )

[iefdev]

If that's on a branch and the time-to-build isn't egregious, liekly Travis Build here will let you know if it works on 10.11 (xcode 7.3 is run on 10.11 I believe: https://paste.macports.org/6da7256b95d3 )

Thanks! Great tip. That would maybe be worth a try. Maybe add it without the if condition, and see where at what version it fails. The build time wouldn't increase as it's just adding the support/option. The deps for dnstap though… The protobuf-c took an eon to build. One of the reasons I put it in a variant.

I'll look more into it later. Perhaps for next upgrade. They'll have their DoH thing coming next time (I think/hope). I'm really exited about that one.

• https://twitter.com/NLnetLabs/status/1275817476996190209
  • Add downstream DNS-over-HTTPS support to Unbound NLnetLabs/unbound#255