Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add work around for compiling gcc{5,6,7,8} + related libgcc ports on APFS filesystems #834

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

cjones051073
Copy link
Member

@cjones051073 cjones051073 commented Sep 26, 2017

Description

Fixes compilation of gcc{5,6,7,8} and related libgcc ports on APFS filesystems.

Fixes https://trac.macports.org/ticket/54829
Fixes https://trac.macports.org/ticket/54900

Upstream bug report

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81797

Type(s)
  • bugfix
Tested on

macOS 10.13
Xcode 9.0

@mojca
Copy link
Member

mojca commented Sep 26, 2017

@cjones051073
Copy link
Member Author

yes, more or less its the same issue...

@jeremyhu
Copy link
Contributor

Please adjust your comment to include "Fixes https://trac.macports.org/ticket/54829" and also apply the same change to gcc5, gcc6, and gcc8.

@cjones051073
Copy link
Member Author

The same fix did not work for me for gcc6. See the log I posted at.

https://trac.macports.org/ticket/54829

The only thing that has worked for me so far for gcc6 was turing off parallel builds.

use_parallel_build no

@cjones051073
Copy link
Member Author

Wrong link above. The gcc6 log is at

https://trac.macports.org/ticket/54900

I think the best solution here is to revert to just turning off the parrallel builds for all gcc versions for macOS 10.13. The fix in this PR does not seem to be completely reliable...

@cjones051073 cjones051073 changed the title Add work around for compiling gcc7 + libgcc on APFS filesystems Add work around for compiling gcc{5,6,7,8} + libgcc{6,-devel} on APFS filesystems Sep 27, 2017
@cjones051073
Copy link
Member Author

Just for completeness, when(if) this is merged make sure to use the squash option to merge the commits into one.

@raimue
Copy link
Member

raimue commented Sep 27, 2017

The squash button has always been disabled since we started using GitHub. Please squash your commits manually and force-push them to the pull request branch.

@cjones051073
Copy link
Member Author

How do I do that ? I am only familiar with doing it on other systems that have the capability in the UI.

@cjones051073
Copy link
Member Author

p.s. Why not enable this in the UI ? Would it not make things easier ?

@cjones051073
Copy link
Member Author

Don't worry, I figured out how to do it at the CLI.

@raimue
Copy link
Member

raimue commented Sep 27, 2017

@cjones051073 It was not enabled initially as we had many team members unexperienced with Git and GitHub, so we narrowed down the options to a single choice. Let's move the policy discussion to macports-dev as it is not only related to this pull request.

@cjones051073 cjones051073 changed the title Add work around for compiling gcc{5,6,7,8} + libgcc{6,-devel} on APFS filesystems Add work around for compiling gcc{5,6,7,8} + related libgcc ports on APFS filesystems Sep 27, 2017
@cjones051073
Copy link
Member Author

So, are people OK to merge this ? The gcc ports are a dependency for a number of other ports so it would be good to get this workaround out sooner rather than later. I feel a proper fix from upstream might be a while coming.

@mf2k
Copy link
Contributor

mf2k commented Sep 28, 2017

Yes, I think you should merge this.

@cjones051073
Copy link
Member Author

OK, thats enough for me....

@cjones051073 cjones051073 merged commit d12c4bd into macports:master Sep 28, 2017
@cjones051073 cjones051073 deleted the GccAPFSFixes branch September 28, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants