ntfs-3g: update to 2017.3.23

[lbschenkel]

Description

I upgraded the port to 2017.3.23. The workarounds for mtree violations are no longer necessary.
Closes https://trac.macports.org/ticket/53536

Type(s)

• security fix
• enhancement

Tested on

macOS 10.13 17A365
Xcode 9.0 9A235

Verification

Have you

• followed our Commit Message Guidelines?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried a full install with sudo port -vst install?

[lbschenkel]

I forgot to check the "security" checkbox when I submitted, now I don't know how to tell the bot to add the label.

[l2dy]

Why removing this line?

[lbschenkel]

The ports I maintain usually don't have that blank line. Force of the habit.

[l2dy]

Did you test Read/Write NTFS filesystems with this port?

[lbschenkel]

Yes, but just basic sanity checks. I didn't do extensive check of all the tools. There are no downstream patches in this port, so this has the same quality as upstream. I saw an open ticket on Trac and felt like I could contribute — the intent here was to upgrade the latest upstream version and avoid the security vulnerabilities of the current packaged version. I'm just a very occasional user of this port though, so I'm not taking maintainership as I usually do for other orphaned ports that I happen to use more frequently.

[l2dy]

@mf2k You used --enable-mount-helper in the patch you submitted on Trac, what was it for?

[lbschenkel]

It was not my patch.

[l2dy]

@lbschenkel I know, and I @-ed the author of that patch.

[l2dy]

@lbschenkel You should put Closes https://trac.macports.org/ticket/53536 into the commit message or else the ticket won't be automatically closed.

[lbschenkel]

Sorry, overlooked the @. My mistake.

But I can tell it what's for: it also builds a mount helper that allows mounting filesystems directly from the finder. However, that violates mtree because they must be put on /sbin and since the current port does not install it (as far as I'm aware, but I didn't install it to check), I didn't bother to include it. If somebody else wants to take this PR and improve it, I don't mind at all. It was just a low-hanging fruit for me.

Regarding the commit message, I'll amend it.

[lbschenkel]

I forgot to say that due to SIP in recent macOS versions, you can't install anything to /sbin or /usr/sbin without booting into recovery and manually copying the binaries. I wonder how many users actually do it (if you're advanced enough to do that, you probably know how to mount via the command line too). I suggest dealing with the mount helper in a separate PR, and allow users to upgrade to the newer version in the meantime, but that's your call.

[mf2k]

I honestly don't remember the reason for adding --enable-mount-helper anymore. I think it made sense when I looked into updating it. I may have gotten that from the build documentation, but I can't find where I saw it right now. I might also have gotten it from playing with ./configure --help.