Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnss-sdr[-devel]: requires thread_local #8761

Merged
merged 1 commit into from Oct 14, 2020

Conversation

chrstphrchvz
Copy link
Contributor

Description

Build failure observed on macOS 10.10:

In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_gnss-sdr/gnss-sdr-devel/work/gnss-sdr-4e0391f4947aabc8e83561e46e1b010bc12affae/src/algorithms/libs/geofunctions.cc:22:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_gnss-sdr/gnss-sdr-devel/work/gnss-sdr-4e0391f4947aabc8e83561e46e1b010bc12affae/src/algorithms/libs/geofunctions.h:29:
In file included from /opt/local/include/armadillo:112:
/opt/local/include/armadillo_bits/arma_rng.hpp:27:10: error: thread-local storage is not supported for the current target
  extern thread_local arma_rng_cxx11 arma_rng_cxx11_instance;
         ^

Maybe other armadillo dependents are affected as well.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@carlesfernandez for port gnss-sdr.
@michaelld for port gnss-sdr.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Oct 12, 2020
@macportsbot
Copy link

Travis Build #14584 Passed.

Lint results
--->  Verifying Portfile for gnss-sdr
--->  0 errors and 0 warnings found.

The build timed out.

Copy link
Contributor

@michaelld michaelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; thx!

@michaelld michaelld merged commit e322a6c into macports:master Oct 14, 2020
@chrstphrchvz chrstphrchvz deleted the patch-18 branch October 14, 2020 01:10
@chrstphrchvz
Copy link
Contributor Author

chrstphrchvz commented Oct 14, 2020

I'm not sure why, but on macOS 10.10, Xcode < 8 isn't being avoided, so the builds are still failing with error: thread-local storage is not supported for the current target.

Edit: this is due to https://trac.macports.org/ticket/61418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
3 participants