Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: add workaround for Tiger #8848

Merged
merged 2 commits into from Oct 20, 2020
Merged

meson: add workaround for Tiger #8848

merged 2 commits into from Oct 20, 2020

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Oct 18, 2020

and peg meson at 55.3 on Tiger as updates are likely fragile
will update meson occasionally, as we do for libuv on Tiger

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.4
Xcode 2.5

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

So -- keeping Tiger alive -- this latest meson fix tries to work around the lack of rpath support in Tiger.

It largely works -- I think better than before, due to some helpful recent changes in meson upstream wherein they seem to be interested in using loader_path themselves for at least some of the in-tree executables.

Appreciate testing by anyone still interested. Perfection is not guaranteed .. (the opposite!) but improvements seem present.

and peg meson at 55.3 on Tiger  as updates are likely fragile
will update meson occasionally, as we do for libuv on Tiger
@macportsbot
Copy link

Notifying maintainers:
@SoapZA for port meson.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels Oct 18, 2020
@macportsbot
Copy link

Travis Build #14720 Passed.

Lint results
--->  Verifying Portfile for meson
--->  0 errors and 0 warnings found.

Port meson success on xcode10.3. Log
Port meson success on xcode9.4. Log
Port meson success on xcode8.3. Log

@kencu
Copy link
Contributor Author

kencu commented Oct 18, 2020

The remaining issue I'm finding is when building documentation -- that still errors sometimes, so I've had to disable the documentation building on a couple of gnome ports, eg https://github.com/kencu/TigerPorts/blob/68c148b0a916490825690fe725135f8b130de128/devel/atk/Portfile#L39

@kencu
Copy link
Contributor Author

kencu commented Oct 19, 2020

Well, I would dearly love to fix the gnome scanner part in meson, but a few hours of poking around did not come up with the magic incantation so far. What does work is to set DYLD_LIBRARY_PATH during destroot to the folder containing the library, so that's what I've been doing lately.

I have one tiny bit to add -- to fix machine detection for "power macintosh" systems, and then I'll push this through.

machintosh -> macintosh
@kencu kencu merged commit 8d187d0 into macports:master Oct 20, 2020
@kencu kencu deleted the tigermesonfix branch October 20, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
3 participants