Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-*: py39 support for matplotlib dependencies #8865

Closed
wants to merge 8 commits into from

Conversation

erikbs
Copy link
Contributor

@erikbs erikbs commented Oct 20, 2020

Description

Adds py39 support for these Python packages:

  • dbus-python
  • py-gobject
  • py-pyqt4
  • py-pyqt5
  • py-pyside
  • py-shiboken
  • py-sip
  • py-sphinx_rtd_theme

This shoud allow all py-matplotlib variants to be installed without dependency issues.

Since Python 3.9 removed tp_print (deprecated since 3.8), a patch was necessary to build py-gobject and py-shiboken successfully. According to the Python docs, tp_print has not done anything since Python 3.0.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.9.5 13F1911
Xcode 6.2 6C131e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port dbus-python.
@michaelld for port py-pyqt4, py-sip.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: enhancement labels Oct 20, 2020
@erikbs erikbs mentioned this pull request Oct 20, 2020
10 tasks
@macportsbot
Copy link

Travis Build #14754 Passed.

Lint results
--->  Verifying Portfile for dbus-python
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-gobject
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pyqt4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pyqt5
Error: Line 110 repeats inclusion of PortGroup qmake5
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for py-pyside
Warning: missing recommended checksum type: size
--->  0 errors and 1 warnings found.
--->  Verifying Portfile for py-shiboken
Warning: missing recommended checksum type: size
--->  0 errors and 1 warnings found.
--->  Verifying Portfile for py-sip
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-sphinx_rtd_theme
--->  0 errors and 0 warnings found.

Port dbus-python39 success on xcode10.3. Log
Port dbus-python success on xcode10.3. Log
Port dbus-python27 success on xcode10.3. Log
Port dbus-python35 success on xcode10.3. Log
Port dbus-python36 success on xcode10.3. Log
Port dbus-python37 success on xcode10.3. Log
Port dbus-python38 success on xcode10.3. Log
Port py38-gobject success on xcode10.3. Log
Port py-gobject success on xcode10.3. Log
Port py27-gobject success on xcode10.3. Log
Port py35-gobject success on xcode10.3. Log
Port dbus-python39 success on xcode9.4. Log
Port dbus-python success on xcode9.4. Log
Port dbus-python27 success on xcode9.4. Log
Port dbus-python35 success on xcode9.4. Log
Port dbus-python36 success on xcode9.4. Log
Port dbus-python37 success on xcode9.4. Log
Port dbus-python38 success on xcode9.4. Log
Port py38-gobject success on xcode9.4. Log
Port py-gobject success on xcode9.4. Log
Port py27-gobject success on xcode9.4. Log
Port py35-gobject success on xcode9.4. Log
Port py36-gobject success on xcode9.4. Log
Port dbus-python39 success on xcode8.3. Log
Port dbus-python success on xcode8.3. Log
Port dbus-python27 success on xcode8.3. Log
Port dbus-python35 success on xcode8.3. Log
Port dbus-python36 success on xcode8.3. Log
Port dbus-python37 success on xcode8.3. Log
Port dbus-python38 success on xcode8.3. Log
Port py38-gobject success on xcode8.3. Log
Port py-gobject success on xcode8.3. Log
Port py27-gobject success on xcode8.3. Log
Port py35-gobject success on xcode8.3. Log
Port py36-gobject success on xcode8.3. Log
Port py37-gobject success on xcode8.3. Log
Port dbus-python39 success on xcode7.3. Log
Port dbus-python success on xcode7.3. Log
Port dbus-python27 success on xcode7.3. Log
Port dbus-python35 success on xcode7.3. Log
Port dbus-python36 success on xcode7.3. Log
Port dbus-python37 success on xcode7.3. Log
Port dbus-python38 success on xcode7.3. Log
Port py38-gobject success on xcode7.3. Log
Port py-gobject success on xcode7.3. Log
Port py27-gobject success on xcode7.3. Log
Port py35-gobject success on xcode7.3. Log
Port py36-gobject success on xcode7.3. Log
Port py37-gobject success on xcode7.3. Log
Port py39-gobject success on xcode7.3. Log

The build timed out.

@michaelld
Copy link
Contributor

Some of these -- like the ones I'm tagged on: py-sip and py-pyqt4 -- have already had the py39 subport added ... here #8799

@michaelld
Copy link
Contributor

Not sure why Github thinks this can be merged ... but it does need to be updated and/or rebased before merging.

@erikbs
Copy link
Contributor Author

erikbs commented Oct 27, 2020

My apologies, I checked my browser history and see now that by mistake I had only searched closed pull requests, thus missing the one you referenced. I am closing this one and creating new, separate pull requests for the remaining packages: py-gobject, py-pyside, py-shiboken and py-sphinx_rtd_theme.

@michaelld
Copy link
Contributor

NP & thanks for dealing with this quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
4 participants