Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobject-introspection: tweak scanner patch #8985

Merged
merged 1 commit into from Nov 3, 2020

Conversation

michaelld
Copy link
Contributor

@michaelld michaelld commented Oct 30, 2020

Now handles build-provided library paths more robustly, removing those that are already found via PKGCONFIG and are thus clearly "system" paths -- for MacPorts the most critical is -L${MACPORTS_PREFIX}/lib ...

Ref: https://trac.macports.org/ticket/61382

Tested on 10.15 and 11.0. Works for py38-gobject3, gexiv2, and libsoup.

Now handles build-provided library paths more robustly, removing those that are found via PKGCONFIG and are thus clearly "system" paths.

Ref: https://trac.macports.org/ticket/61382
@macportsbot
Copy link

Notifying maintainers:
@dbevans for port gobject-introspection.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port labels Oct 30, 2020
@macportsbot
Copy link

Travis Build #14983 Passed.

Lint results
--->  Verifying Portfile for gobject-introspection
--->  0 errors and 0 warnings found.

Port gobject-introspection success on xcode10.3. Log
Port gobject-introspection success on xcode9.4. Log
Port gobject-introspection success on xcode8.3. Log
Port gobject-introspection success on xcode7.3. Log

@dbevans
Copy link
Contributor

dbevans commented Nov 2, 2020

OK, let me try this out. Hopefully it will fix the issues generated by the last commit 😉

@michaelld
Copy link
Contributor Author

OK, let me try this out. Hopefully it will fix the issues generated by the last commit 😉

Please do & yes hopefully! I've had good success with this PR's changes on various macOS & the ports listed ... in my testing it's pretty robust, covering a lot more situations than the initial change. There is the likely chance of corner cases, of course ... but I don't think they'll be difficult to fix once we know them!

@dbevans
Copy link
Contributor

dbevans commented Nov 2, 2020

Tested ok with babl and gegl. So far so good. Will run a more exhaustive test over night and report back tomorrow. Keep your fingers crossed.

@dbevans dbevans mentioned this pull request Nov 2, 2020
11 tasks
Copy link
Contributor

@dbevans dbevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing a lot of GNOME ports that use gobject-introspection, I didn't find any specific problems although there may be some lurking somewhere. I didn't find any but then I didn't rebuild all ports that use gobject-introspection either.

In any case, I propose to go ahead and merge this and then commit a number of updates that depend on it (including poppler). If there's something that can go wrong, that should flush it out. Thanks for all your work on this and the preceding PRs.

@dbevans dbevans merged commit 8fb4974 into macports:master Nov 3, 2020
@michaelld michaelld deleted the go-i_tweak_L_settings branch November 4, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
3 participants