HexFiend: update to 2.13.1

[Tatsh]

Description

https://trac.macports.org/ticket/57824

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.15.7 19H2
Xcode 12.1 12A7403

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried existing tests with sudo port test? n/a
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@neverpanic for port HexFiend.

[macportsbot]

Travis Build #15045 Passed.

Lint results

--->  Verifying Portfile for HexFiend
--->  0 errors and 0 warnings found.

Port HexFiend success on xcode10.3. Log
Port HexFiend-framework fail on xcode10.3. Log
Port HexFiend fail on xcode9.4. Log
Port HexFiend-framework fail on xcode9.4. Log
Port HexFiend fail on xcode8.3. Log
Port HexFiend-framework fail on xcode8.3. Log
Port HexFiend fail on xcode7.3. Log

[mf2k]

You need to add the reference to the Trac ticket to the commit message:

Closes: https://trac.macports.org/ticket/57824

[macportsbot]

Travis Build #15047 Passed.

Lint results

--->  Verifying Portfile for HexFiend
--->  0 errors and 0 warnings found.

Port HexFiend success on xcode10.3. Log
Port HexFiend-framework fail on xcode10.3. Log
Port HexFiend fail on xcode9.4. Log
Port HexFiend-framework fail on xcode9.4. Log
Port HexFiend fail on xcode8.3. Log
Port HexFiend-framework fail on xcode8.3. Log
Port HexFiend fail on xcode7.3. Log
Port HexFiend-framework fail on xcode7.3. Log

[Tatsh]

You need to add the reference to the Trac ticket to the commit message:

Closes: https://trac.macports.org/ticket/57824

Done.

[macportsbot]

Travis Build #15048 Passed.

Lint results

--->  Verifying Portfile for HexFiend
--->  0 errors and 0 warnings found.

Port HexFiend success on xcode10.3. Log
Port HexFiend-framework fail on xcode10.3. Log
Port HexFiend fail on xcode9.4. Log
Port HexFiend-framework fail on xcode9.4. Log
Port HexFiend fail on xcode8.3. Log
Port HexFiend-framework fail on xcode8.3. Log
Port HexFiend fail on xcode7.3. Log
Port HexFiend-framework fail on xcode7.3. Log

[neverpanic]

The hexfiend-framework subport seems to fail. However, the Hexfiend port seems to install the Framework in /Applications/MacPorts/Hex Fiend.app/Contents/Frameworks/HexFiend.framework/. Maybe we should just drop the subport?

[Tatsh]

The hexfiend-framework subport seems to fail. However, the Hexfiend port seems to install the Framework in /Applications/MacPorts/Hex Fiend.app/Contents/Frameworks/HexFiend.framework/. Maybe we should just drop the subport?

I think so. I don't see anything depending on the HexFiend framework package.

[neverpanic]

Can you push a change that just drops it? I don't think there's a big point in explicitly marking it as obsoleted either.

[neverpanic]

If this passes CI, I'm merging it.

[macportsbot]

Travis Build #15051 Passed.

Lint results

--->  Verifying Portfile for HexFiend
--->  0 errors and 0 warnings found.

Port HexFiend success on xcode10.3. Log
Port HexFiend fail on xcode9.4. Log
Port HexFiend fail on xcode8.3. Log
Port HexFiend fail on xcode7.3. Log

[neverpanic]

This fails on 10.13 with

/opt/local/var/macports/build/_Users_travis_build_macports_macports-ports_editors_HexFiend/HexFiend/work/ridiculousfish-HexFiend-5a08e1f/framework/sources/HFFunctions.m:955:66: error: use of undeclared identifier 'NSAppearanceNameDarkAqua'; did you mean 'NSAppearanceNameAqua'?

I'm assuming the versions below that will also not work.

Should we modify the block at the bottom to be ${os.major} < 14 and modify the error message?

The Azure 10.14 build fails with what seems to be a permission problem, but according to https://trac.macports.org/ticket/61392 there are currently some problems with that, so I wouldn't consider that blocking.

[Tatsh]

If that's the only error we might be able to patch it to work on 10.13 but unfortunately right now I have no way to test locally.

On the latest HEAD they are using more new constants that are not available in older SDKs so this is a kind of an ongoing issue. Unfortunately it looks like upstream is too willing to drop older SDKs and Xcode versions.

The binary should still work on 10.12 and above. Would need an update from upstream on what macOS versions they intend to support.

[neverpanic]

The build on 10.14 passes for me locally with this patch:

diff --git a/editors/HexFiend/Portfile b/editors/HexFiend/Portfile
index 08ec3cdddbc..cccfa99e8bc 100644
--- a/editors/HexFiend/Portfile
+++ b/editors/HexFiend/Portfile
@@ -28,10 +28,6 @@ long_description \n\
     * Smooth scrolling. No separate pages - scroll like any text document.

 supported_archs x86_64
-macosx_deployment_target 10.8
-
-# The project only works with Xcode >= 8
-minimum_xcodeversions {11 8.0}

 patch.pre_args  -p1
 patchfiles      0001-xcode-Disable-Sparkle.patch

Can you apply that and increase the version filter at the bottom? There may be ways to make HexFiend work on 10.13 and lower, but for now it doesn't, so I'd rather have it fail quickly than waste users' time just to end up with a broken build.