Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minipro: update 0.5 #9065

Merged
merged 6 commits into from Jan 26, 2021
Merged

minipro: update 0.5 #9065

merged 6 commits into from Jan 26, 2021

Conversation

krischik
Copy link
Contributor

@krischik krischik commented Nov 9, 2020

Description

  • project moved from github to gitlab
  • change maintainer as @ranauei doesn't exist and will break the CI build.
  • current version is 0.5
  • minipro-query-db command has been removed
  • Makefile now supports PREFIX option
  • Makefile now supports install with DESTROOT option.
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.7 19H15
Xcode 12.1 12A7403

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@ranauei for port minipro.

@macportsbot
Copy link

Travis Build #15114 Passed.

Lint results
--->  Verifying Portfile for minipro
--->  0 errors and 0 warnings found.

Port minipro success on xcode10.3. Log
Port minipro success on xcode9.4. Log
Port minipro success on xcode8.3. Log
Port minipro success on xcode7.3. Log

@herbygillot
Copy link
Member

Once you feel that things are in a good state, please squash your commits into a single commit, and force-push.

@krischik
Copy link
Contributor Author

Once you feel that things are in a good state, please squash your commits into a single commit, and force-push.

I don't know how to do that and this is voluntary work there is only that much time I am prepared to spend on your nit picking. Take it or leave it.

Copy link
Contributor

@ryandesign ryandesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a problem for us to squash everything into one commit using the GitHub web interface when we merge it.

While I understand that your time is limited, you should be prepared for others to review the work you submit. We are all trying to work together to help MacPorts continue to be a consistent high-quality product.

categories devel
maintainers openmaintainer {gmail.com:ranauei @ranauei}
maintainers openmaintainer {krischik @krischik}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, GitHub handle @ranauei doesn't exist today. I feel fairly certain that it did exist when I added it to the ports this person maintains in #1796.

Did you contact this person by email to discover if they have a new GitHub handle or if they still wish to maintain this port?

This person maintains other ports. The maintainers line of all the ports should be fixed simultaneously.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now filed a port abandonment ticket for this.

Copy link
Contributor

@kencu kencu Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is why I didn't:

I first saw this was a ticket submission from 6 years ago, committed by Kurt. The submitted version was 0.0.1.

We have never seen or heard from the supposed maintainer since, in five years.

All the changes in the port since being committed initially were mostly done by you and larry.

The supposed maintainer has no other ports.

So -- IMHO -- this did not need a port abandonment ticket, as it was clearly either abandoned at birth or immediately post-partum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said above:

This person maintains other ports. The maintainers line of all the ports should be fixed simultaneously.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is fair.

@@ -14,9 +14,15 @@ long_description Opensource tool that aims to create a complete cross-platfor
Currently it supports more than 13000 of target devices including \
AVRs, PICs as well as a huge number of other microcontrollers and \
various BIOSes.
homepage https://gitlab.com/DavidGriffith/minipro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as the github portgroup helps simplify ports hosted at github, the gitlab portgroup should be used to simplify ports hosted using gitlab.

devel/minipro/Portfile Outdated Show resolved Hide resolved
@ryandesign ryandesign mentioned this pull request Nov 11, 2020
9 tasks
Co-authored-by: Ryan Schmidt <ryandesign@macports.org>
@kencu kencu merged commit 1bbe3d3 into macports:master Jan 26, 2021
@krischik krischik deleted the support/minipro-0.5 branch January 27, 2021 13:07
breun pushed a commit to breun/macports-ports that referenced this pull request Jan 27, 2021
@ryandesign ryandesign mentioned this pull request Feb 3, 2021
11 tasks
ryandesign added a commit that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants