primegen: fix errors when compiling using Xcode 12 #9473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macportsbot
added
maintainer
maintainer: open
|
Thanks for this submission, @toy. However one comment: the commit message should start with the port name. So the message should look like:
|
Fix issues in code that are causing error in Xcode 12 and caused warnings in previous versions. Namely include missing stdio.h, use int as return type for main and use return instead of exit in main. Closes: https://trac.macports.org/ticket/61870
toy
force-pushed
the
math-primegen-modernise-code
branch
from
fe51368
to
d8e3b92
Compare
|
Thanks for quick reply @herbygillot, I fixed the subject and force-pushed. |
Looks good. We'll leave the PR open for a bit longer for others to review. Thanks again. |
ryandesign
reviewed
Dec 29, 2020
ryandesign
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issues in code that are causing error in Xcode 12 and caused warnings in previous versions. Namely include missing stdio.h, use int as return type for main and use return instead of exit in main.
https://trac.macports.org/ticket/61870
Type(s)
Tested on
macOS 10.15.7 19H15
Xcode 12.3 12C33
Verification
Have you
port lint?sudo port -vst install?