openmpi: add subport clang11

[mascguy]

Description

Add new subport clang11, for openmpi.

Resolves issue 61879 - Add clang11 sub-port to openmpi

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.8.5 12F2560
Xcode 5.1.1 5B1008

macOS 10.12.6 16G2136
Xcode 9.2 9C40b

macOS 10.13.6 17G14019
Xcode 10.1 10B61

macOS 10.14.6 18G103
Xcode 11.3.1 11C505

macOS 10.15.6 19G2021
Xcode 12.0 12A7209

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[g5pw]

👍🏻, merging, thanks for your contribution to MacPorts!

[ryandesign]

Thank you, however:

Resolves issue 61879 - Add clang11 sub-port to openmpi

In the future please make sure that you follow our commit message requirements to include proper references to tickets, so that Trac can automatically close tickets that a commit resolves. For more guidance about commit messages, see https://trac.macports.org/wiki/CommitMessages

Also, please make sure that you only increase a port's revision when it's necessary to do so. In a port with subports, that means making sure you only increase the revision of the subports that your commit affects. You increased the revision of this port as a whole, which effectively increased the revision of all of its subports that did not declare individual revisions (which was all of the non-devel subports) but all you were doing was adding a new subport, so no revision increase for any subport was necessary. By increasing the revision you caused all of the existing non-devel subports to be rebuilt unnecessarily. Given how large openmpi is and how many subports it has, this was hours of wasted CPU time both on our build systems and on some user systems where a build from source might have been necessary. For more guidance about revisions, see https://guide.macports.org/chunked/reference.html#reference.keywords

[mascguy]

Wow, this was a total screw-up on my part.My appologies Ryan, I hadn't intended to bump the revision in this particular case. Crap!On Jan 8, 2021 06:01, Ryan Schmidt <notifications@github.com> wrote: Thank you, however: Resolves issue 61879 - Add clang11 sub-port to openmpi In the future please make sure that you follow our commit message requirements to include proper references to tickets, so that Trac can automatically close tickets that a commit resolves. For more guidance about commit messages, see https://trac.macports.org/wiki/CommitMessages Also, please make sure that you only increase a port's revision when it's necessary to do so. In a port with subports, that means making sure you only increase the revision of the subports that your commit affects. You increased the revision of this port as a whole, which effectively increased the revision of all of its subports that did not declare individual revisions (which was all of the non-devel subports) but all you were doing was adding a new subport, so no revision increase for any subport was necessary. By increasing the revision you caused all of the existing non-devel subports to be rebuilt unnecessarily. Given how large openmpi is and how many subports it has, this was hours of wasted CPU time both on our build systems and on some user systems where a build from source might have been necessary. For more guidance about revisions, see https://guide.macports.org/chunked/reference.html#reference.keywords —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.