Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readlineuniversal #9967

Merged
merged 2 commits into from Feb 9, 2021
Merged

Readlineuniversal #9967

merged 2 commits into from Feb 9, 2021

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Feb 9, 2021 •
edited

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
macOS 11.2 20D64
Xcode 12.4 12D4e

and Leopard PPC
macOS 10.5.8
Xcode 3.1.4

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@kencu
readline: remove merger_must_run_binaries
5ac9893 
this disables universal building on BigSur Intel
but appears that this is no longer needed
last was an issue about 7 years ago with a universal
build on PPC Leopard

closes: https://trac.macports.org/ticket/62239
@kencu
readline: remove default code
e4d39dc 
no need to set defaults
@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port readline.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix labels Feb 9, 2021
@kencu
Copy link
Contributor Author

kencu commented Feb 9, 2021

Marcus is clearly not around. I’ll own this commit and fix any unexpected fallout, of which I anticipate none.

@kencu kencu merged commit b426301 into macports:master Feb 9, 2021
@kencu kencu deleted the readlineuniversal branch February 17, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
Milestone
No milestone
3 participants
@kencu @macportsbot @MarcusCalhoun-Lopez