Move resources from base to ports #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverpanic
reviewed
Oct 6, 2016
There was a problem hiding this comment.
We previously used different branching styles; sometimes, we only copied the base folder, sometimes we copied the contents of the base folder and in some cases, we even branched the whole trunk folder. Because of this, you need the additional rules if you want to correctly map changes to resources in those branches.
|
I've fixed this PR to do the move properly in all branches, modeled on what you did in 8f67d42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to move resources from base to ports, but I'm not sure if this PR is sufficient. Does it need the more involved treatment you used in 8f67d42 to move the infrastructure scripts?