Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license conversion #18

Merged
merged 1 commit into from May 31, 2019
Merged

Update license conversion #18

merged 1 commit into from May 31, 2019

Conversation

Korusuke
Copy link
Member

Return unknown if no license found and test for the same

Fixes #14

Return unknown if no license found and test for the same

Fixes macports#14
@Korusuke Korusuke added this to the GSoC Week 1 milestone May 29, 2019
@Korusuke Korusuke mentioned this pull request May 29, 2019
@Korusuke Korusuke requested review from reneeotten and Steap and removed request for reneeotten May 29, 2019 09:24
@reneeotten
Copy link
Contributor

@Korusuke this seems to work as intended, but the return-statement becomes a bit hard to decipher... not sure if that's a real issue but readability does count to a certain point. @Steap what do you think?

@Steap
Copy link
Collaborator

Steap commented May 30, 2019

It is not super elegant, but having an "if/else" may not be that much better. I think it is down to personal preference here.

@reneeotten
Copy link
Contributor

okay, let's merge this then

@reneeotten reneeotten merged commit e9e40f0 into macports:master May 31, 2019
@Korusuke Korusuke deleted the license branch May 31, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update port
3 participants